Skip to content

Conversation

@loftwah
Copy link
Contributor

@loftwah loftwah commented Jul 16, 2022

Describe your changes:

Updated all path in await page.goto to include a ./ instead of /
await page.goto('./', { waitUntil: 'networkidle' });

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@codecov
Copy link

codecov bot commented Jul 16, 2022

Codecov Report

Merging #5520 (ae73a39) into master (7e854f0) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5520      +/-   ##
==========================================
- Coverage   53.67%   53.62%   -0.06%     
==========================================
  Files         594      594              
  Lines       21781    21781              
  Branches     2049     2049              
==========================================
- Hits        11692    11679      -13     
- Misses       9513     9526      +13     
  Partials      576      576              
Flag Coverage Δ *Carryforward flag
e2e-ci 37.66% <ø> (-1.77%) ⬇️
e2e-full 48.80% <ø> (+<0.01%) ⬆️ Carriedforward from 41e42b3
unit 50.08% <ø> (-0.07%) ⬇️ Carriedforward from 41e42b3

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
src/utils/template/templateHelpers.js 50.00% <0.00%> (-50.00%) ⬇️
...c/plugins/persistence/couch/CouchObjectProvider.js 78.64% <0.00%> (-1.70%) ⬇️
src/plugins/tabs/components/tabs.vue 34.40% <0.00%> (-1.61%) ⬇️
src/plugins/imagery/components/ImageryView.vue 37.12% <0.00%> (-0.70%) ⬇️
src/plugins/gauge/components/Gauge.vue 61.72% <0.00%> (-0.62%) ⬇️
src/plugins/plot/draw/Draw2D.js 87.93% <0.00%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e854f0...ae73a39. Read the comment docs.

@unlikelyzero unlikelyzero changed the title [e2e] Update tests to be compatible with viper #5513 [CLA Needed] [e2e] Update tests to be compatible with viper #5513 Jul 16, 2022
@loftwah
Copy link
Contributor Author

loftwah commented Jul 18, 2022

I have pre-emptively filled out and submitted a contributor license agreement that I found here

@ozyx ozyx changed the title [CLA Needed] [e2e] Update tests to be compatible with viper #5513 [CLA Submitted] [e2e] Update tests to be compatible with viper #5513 Jul 18, 2022
@ozyx ozyx added the source:community Community contribution or request label Jul 19, 2022
@unlikelyzero unlikelyzero self-requested a review July 25, 2022 20:15
@unlikelyzero unlikelyzero enabled auto-merge (squash) July 25, 2022 20:15
Copy link
Contributor

@unlikelyzero unlikelyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome aboard 🚀

@unlikelyzero unlikelyzero merged commit 7e13374 into nasa:master Jul 25, 2022
@loftwah
Copy link
Contributor Author

loftwah commented Jul 26, 2022

Thanks, I will get into the next task this week, I meant to do it earlier but things have been pretty flat out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

source:community Community contribution or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants