Skip to content

Fix hostname resolution for proxied connections #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+285 −1
Open

Fix hostname resolution for proxied connections #913

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f162017
Fix hostname resolution for proxied connections
bartosz822 May 15, 2023
465b0e6
Do not use `InetSocketAddress.createUnresolved` for uris already cont…
bartosz822 May 15, 2023
8d9679d
Add unit test
bartosz822 Oct 31, 2025
45da71d
Add enableInetAddressCreateUnresolved option
bartosz822 Nov 5, 2025
50de4f1
Fix test on ci
bartosz822 Nov 6, 2025
0c62723
Merge branch 'nats-io:main' into fix-proxy-hostname-resolution
bartosz822 Nov 7, 2025
d5c8338
Try to fix tests on CI once again
bartosz822 Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/io/nats/client/impl/SocketDataPort.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,9 @@ public void connect(@NonNull NatsConnection conn, @NonNull NatsUri nuri, long ti
socket = connectToFastestIp(options, host, port, (int) timeout);
} else {
socket = createSocket(options);
socket.connect(new InetSocketAddress(host, port), (int) timeout);
InetSocketAddress inetSocketAddress = (options.isNoResolveHostnames() && !nuri.hostIsIpAddress()) ?
InetSocketAddress.createUnresolved(host, port) : new InetSocketAddress(host, port);
socket.connect(inetSocketAddress, (int) timeout);
}

if (options.getSocketReadTimeoutMillis() > 0) {
Expand Down