Add validation for subjects #1017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds and add comprehensive test coverage
…zation and remove dot-based validation tests
…bject validation details in comments and documentation
Expanded tests to include separate validations for short (<16 chars) and long (≥16 chars) subject paths, with specific checks for whitespace handling.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…n `SubjectValidator`, remove inline checks, and streamline public APIs. Update tests for comprehensive validation coverage.
…s. Split `ProtocolWriterTests` into focused test classes and improve test coverage for whitespace handling and edge cases.
Ensure subject and queue group validation occurs before async operations in `SubscribeAsync`, `SubscribeCoreAsync`, and `RequestManyAsync`. Update tests to verify synchronous exceptions and add comprehensive validation coverage.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…nc` implementations. Update tests to improve clarity and replace unused variable names. Resolve BenchmarkDotNet dependency conflict for `net481`.
Member
Author
|
Member
Author
|
Member
Author
|
Member
Author
> dotnet run -c Release --framework net8.0 -- --filter "*SubjectValidation*" |
… subject validation methods.
Merged
mtmk
added a commit
that referenced
this pull request
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add subject/replyTo/queueGroup validation to prevent protocol-breaking input from reaching the wire.
Validation rules:
Opt-In:
Validation is turned off by default to not break any existing installations. You can turn it on:
Exception Handling:
Validation exception is thrown at the point of the calls on the same execution thread. This will give the application immediate feedback and stack trace where the invalid string is used.
Performance Impact Summary:
(*) Long subject results on .NET Framework show measurement variability due to GC timing differences between benchmark runs.
Subject validation adds negligible overhead on .NET 8.0, the primary target runtime. The validation uses
SearchValues<char>with SIMD on .NET 8+ and an optimized manual loop for short subjects (<16 chars).The validation is allocation free on all frameworks.
See comments below for benchmark run results.