Skip to content

Conversation

@mtmk
Copy link
Member

@mtmk mtmk commented Jan 6, 2026

Fixes #1029

@mtmk mtmk requested review from caleblloyd and scottf January 6, 2026 11:35
Copy link
Collaborator

@caleblloyd caleblloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good. A future improvement to the test could be using something like Microsoft.DotNet.ApiCompat.Tool to check compat

Copy link
Contributor

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtmk mtmk merged commit 392cee9 into main Jan 8, 2026
21 checks passed
@mtmk mtmk deleted the fix-abi-compat branch January 8, 2026 11:02
mtmk added a commit that referenced this pull request Jan 8, 2026
* Fix OTel INatsJSMsg extension (#1031)
* Fix 2.6/2.7 ABI for serializer interfaces (#1032)
@mtmk mtmk mentioned this pull request Jan 8, 2026
mtmk added a commit that referenced this pull request Jan 8, 2026
* Fix OTel INatsJSMsg extension (#1031)
* Fix 2.6/2.7 ABI for serializer interfaces (#1032)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2.7.0 INatsSerialize ABI break in INatsSerialize

4 participants