-
Notifications
You must be signed in to change notification settings - Fork 89
Implement Lame Duck Mode Event Handler #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
edda667 to
15f7ac2
Compare
|
@pzajaczkowski thanks for the PR. long overdue that issue ;)
I think that's fine.
Potentially passing the host might be a interesting. EDIT: What do you think about passing |
The LDM request feature test uses added to server version 2.10.
mtmk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @pzajaczkowski
Resolves #23
I had two ideas for approaching this issue:
WritableServerInfoproperty and add setter, that will check if LDM has changed totrueNatsConnectionand invoke it directly fromNatsReadProtocolProcessorafter recieving INFO from server with LDM.I decided to go with first option.
There is one thing i am not sure of: should anything be passed as argument to the
LameDuckModeActivatedevent? Currently, it is an empty string.