Skip to content

Fix reader buffer bug with typo #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mtmk merged 1 commit into from
Apr 5, 2025
Merged

Fix reader buffer bug with typo #799

mtmk merged 1 commit into from
Apr 5, 2025

Conversation

@mtmk
Copy link
Member

@mtmk mtmk commented Mar 31, 2025

No description provided.

@mtmk mtmk linked an issue Mar 31, 2025 that may be closed by this pull request
System.ArgumentOutOfRangeException in logs #796
Closed
@mtmk
Copy link
Member Author

mtmk commented Apr 2, 2025

@Vlad-Zaytsev are you able to test this PR in your environment?

@Vlad-Zaytsev
Copy link

Vlad-Zaytsev commented Apr 3, 2025

@Vlad-Zaytsev are you able to test this PR in your environment?

No. I'm sorry, but it occures only in production. (and no longer occures actualy)

@mtmk
Copy link
Member Author

mtmk commented Apr 3, 2025

@Vlad-Zaytsev are you able to test this PR in your environment?

No. I'm sorry, but it occures only in production. (and no longer occures actualy)

no worries, thanks for confirming that. inspecting the code and the exception this is the only call that might have an issue and it's clearly wrong. since it's not happening anymore, just to confirm, the section of the code is only hit if there was a server error send back like authorization violation for example. Can you remember when the error occurred at the time there may have been such errors?

@Vlad-Zaytsev
Copy link

Vlad-Zaytsev commented Apr 4, 2025

@Vlad-Zaytsev are you able to test this PR in your environment?

No. I'm sorry, but it occures only in production. (and no longer occures actualy)

no worries, thanks for confirming that. inspecting the code and the exception this is the only call that might have an issue and it's clearly wrong. since it's not happening anymore, just to confirm, the section of the code is only hit if there was a server error send back like authorization violation for example. Can you remember when the error occurred at the time there may have been such errors?

Maybe. I can not tell for sure.

caleblloyd
caleblloyd approved these changes Apr 5, 2025
View reviewed changes
Copy link
Collaborator

@caleblloyd caleblloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me!

@mtmk mtmk merged commit 652d226 into main Apr 5, 2025
13 checks passed
@mtmk mtmk deleted the 796-systemargumentoutofrangeexception-in-logs branch April 5, 2025 11:44
mtmk added a commit that referenced this pull request Apr 9, 2025
@mtmk
Release 2.5.14
14ea8f9 
* Fix heartbeat timer to prevent unnecessary pulls (#794)
* Inbox Subscription Memory leak .NetStandard2.0 (#803)
* Fix reader buffer bug with typo (#799)
* Fix handling for OnNoData when ignoring deletes (#790)
@mtmk mtmk mentioned this pull request Apr 9, 2025
Merged
mtmk added a commit that referenced this pull request Apr 9, 2025
@mtmk
Release 2.5.14 (#815)
c5e4e02 
* Fix heartbeat timer to prevent unnecessary pulls (#794)
* Inbox Subscription Memory leak .NetStandard2.0 (#803)
* Fix reader buffer bug with typo (#799)
* Fix handling for OnNoData when ignoring deletes (#790)
wolfkor pushed a commit to wolfkor/nats.net that referenced this pull request Apr 12, 2025
@mtmk @wolfkor
Fix reader buffer bug with typo (nats-io#799)
f8a34cc
This was referenced Nov 3, 2025
Closed
Merged
@dependabot dependabot bot mentioned this pull request Dec 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caleblloyd caleblloyd caleblloyd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

System.ArgumentOutOfRangeException in logs

4 participants

@mtmk @Vlad-Zaytsev @caleblloyd