-
Notifications
You must be signed in to change notification settings - Fork 89
Add direct request-reply #829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caleblloyd
approved these changes
Apr 15, 2025
Collaborator
caleblloyd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement! LGTM
# Conflicts: # src/NATS.Client.Core/NatsOpts.cs
mtmk
added a commit
that referenced
this pull request
Apr 16, 2025
* Stopped testing with net6.0 (#821) * Update JetStream models (#832) * Add direct request-reply (#829) * Socket Connection Factory (#828) * Fix proxy with TLS scenario with SocketConnectionFactory (#826) * Make NatsJSConstants public (#825) * Use Stopwatch in PingCommand for more precise timing (#827) * Fix netstandard bugs and tidy up tests (#817)
Merged
mtmk
added a commit
that referenced
this pull request
Apr 16, 2025
* Stopped testing with net6.0 (#821) * Update JetStream models (#832) * Add direct request-reply (#829) * Socket Connection Factory (#828) * Fix proxy with TLS scenario with SocketConnectionFactory (#826) * Make NatsJSConstants public (#825) * Use Stopwatch in PingCommand for more precise timing (#827) * Fix netstandard bugs and tidy up tests (#817)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we make the request-reply more efficient by skipping inbox queues, hopefully eliminating of the timeout issues some applications have been experiencing.
Opts.RequestReplyMode Feature flag
Using this flag applications can opt-in to this feature minimizing the risk of experiencing issues where somehow they rely on the existing behavior.
Benchmark
RequestReplyBench: