Skip to content

#848 Tweak dependencies #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mtmk merged 7 commits into from
May 29, 2025
Merged

#848 Tweak dependencies #853

mtmk merged 7 commits into from
May 29, 2025

Conversation

@thompson-tomo
Copy link
Contributor

@thompson-tomo thompson-tomo commented May 12, 2025

Closes #848

mtmk
mtmk reviewed May 12, 2025
View reviewed changes
@mtmk
Copy link
Member

mtmk commented May 12, 2025

thanks @thompson-tomo i like the idea. i must ask though with this change are the applications going to get a benefit as a result of this? what I mean is that, the STJ and SIOP packages will be upgraded by the sdk building them, if used by other packages or the application itself with higher versions. would we be breaking builds or exposing the applications to security issues if the build servers still running old sdks? i know it's a simple change but i want to make sure we cover everything so that we won't break existing builds in some fashion.

@thompson-tomo
Copy link
Contributor Author

thompson-tomo commented May 13, 2025 •
edited
Loading

are the applications going to get a benefit as a result of this?.... exposing the applications to security issues if the build servers still running old sdks?

This depends on how the end application is packaged:

  • Self contained: if build server sdk is not maintained then yes risk is increased as the deployment bundles in the version provided by sdk. But the security risk overall is not significantly increased due to other security risks existing
  • framework dependent: security risks can be addressed by updating framework on target machine ie windows update. This is because the version provided by the framework is used

would we be breaking builds

Only scenario I can foresee is where another library/app targets net 6/7, uses a feature introduced in STJ 7/8 and doesn't have either an explicit or transitive dependency for a version of STJ which includes the necessary feature.

@thompson-tomo
Copy link
Contributor Author

thompson-tomo commented May 13, 2025

Hopefully the build issue has been resolved with the latest changes.

mtmk
mtmk reviewed May 13, 2025
View reviewed changes
@thompson-tomo
Copy link
Contributor Author

thompson-tomo commented May 13, 2025

@mtmk any idea why package restore is only failing on 1 os. Maybe it needs to be re-triggered?

@mtmk
Copy link
Member

mtmk commented May 13, 2025

@mtmk any idea why package restore is only failing on 1 os. Maybe it needs to be re-triggered?

it's interesting it's only failing a couple of them. usually in these cases where there is an issue with build they all fail. kicked it again anyway

@thompson-tomo
Copy link
Contributor Author

thompson-tomo commented May 13, 2025 •
edited
Loading

Agree @mtmk it seems very interesting and that the issue is infrastructure related given that the most recent run only failed 1 project which is now talking about an ssl verification issue. Can you give it another kick?

@mtmk
Copy link
Member

mtmk commented May 16, 2025 •
edited
Loading

just kicked the build again. i'm guessing something funny going on with ci workers nuget sources then when they failed. let's see.

edit: ok good. all passed this time!

@mtmk
Copy link
Member

mtmk commented May 16, 2025 •
edited
Loading

seeing these at the bottom of the diff tab. i wonder if that's a netstandard/ net6 issue

edit: hmm can't be netstandard. sounds like it's an AOT related warning.

image

@thompson-tomo
Copy link
Contributor Author

thompson-tomo commented May 17, 2025

Ok based on dotnet/runtime#58770 they look to be false warnings. Let's see if the suggestion in that issue resolves the warnings. 🤞

@thompson-tomo
Copy link
Contributor Author

thompson-tomo commented May 23, 2025

@mtmk did the last commit resolve the warnings?

@mtmk
Copy link
Member

mtmk commented May 23, 2025

@mtmk did the last commit resolve the warnings?

just kicked the checks

@thompson-tomo thompson-tomo requested a review from mtmk May 24, 2025 04:30
@mtmk
Copy link
Member

mtmk commented May 24, 2025

may i move this PR onto release/2.7?

@thompson-tomo
Copy link
Contributor Author

thompson-tomo commented May 24, 2025

Yes that is fine with me.

@mtmk mtmk changed the base branch from main to release/2.7 May 24, 2025 12:46
@thompson-tomo thompson-tomo force-pushed the chore/#848_TweakDependencies branch from 88c7db1 to c18f7ec Compare May 25, 2025 02:13
@mtmk mtmk added this to the 2.7 milestone May 25, 2025
@thompson-tomo
nats-io#848 Tweak dependencies
5307a55 
Signed-off-by: James Thompson <[email protected]>
@thompson-tomo
Update NATS.Client.Core.csproj
99fb4c8 
Signed-off-by: James Thompson <[email protected]>
@thompson-tomo
Update NATS.Client.Core.csproj
6ea1eb1 
Signed-off-by: James Thompson <[email protected]>
@thompson-tomo
Make STJ explicit dependency for JetStream
1616a26 
Signed-off-by: James Thompson <[email protected]>
@thompson-tomo
Update NATS.Client.JetStream.csproj
b17cefa 
Signed-off-by: James Thompson <[email protected]>
@thompson-tomo
Force sdk to 8.0.0
3eea2f2 
Signed-off-by: James Thompson <[email protected]>
@thompson-tomo
Add newer stj for net 6
2050d60 
Signed-off-by: James Thompson <[email protected]>
@thompson-tomo thompson-tomo force-pushed the chore/#848_TweakDependencies branch from c18f7ec to 2050d60 Compare May 25, 2025 23:56
mtmk
mtmk approved these changes May 29, 2025
View reviewed changes
Copy link
Member

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @thompson-tomo

@mtmk mtmk merged commit 0f7166c into nats-io:release/2.7 May 29, 2025
17 checks passed
@thompson-tomo thompson-tomo deleted the chore/#848_TweakDependencies branch May 30, 2025 00:18
mtmk added a commit that referenced this pull request Jul 18, 2025
@mtmk
Release 2.7.0-preview.1
f74c101 
* #851 Move Serialization Interface into Abstractions (#858)
* Obsolete ReplyAsync method for NatsJsMsg (#839)
* Add support for `Filter` and `Enrich` for OpenTelemetry activities (#859)
* #848 Tweak dependencies (#853)
* #863 Fix naming of consumer group attribute (#870)
@mtmk mtmk mentioned this pull request Jul 18, 2025
Merged
mtmk added a commit that referenced this pull request Jul 18, 2025
@mtmk
Release 2.7.0-preview.1 (#905)
97561b7 
* #851 Move Serialization Interface into Abstractions (#858)
* Obsolete ReplyAsync method for NatsJsMsg (#839)
* Add support for `Filter` and `Enrich` for OpenTelemetry activities (#859)
* #848 Tweak dependencies (#853)
* #863 Fix naming of consumer group attribute (#870)
@mtmk mtmk mentioned this pull request Sep 22, 2025
Merged
mtmk added a commit that referenced this pull request Dec 19, 2025
@mtmk @thompson-tomo
@aradalvand @yeongjonglim @regnrat
Release 2.7 (#874)
4856762 
* #863 Fix naming of consumer group attribute (#870)

Signed-off-by: James Thompson <[email protected]>

* #848 Tweak dependencies (#853)

* #848 Tweak dependencies

Signed-off-by: James Thompson <[email protected]>

* Update NATS.Client.Core.csproj

Signed-off-by: James Thompson <[email protected]>

* Update NATS.Client.Core.csproj

Signed-off-by: James Thompson <[email protected]>

* Make STJ explicit dependency for JetStream

Signed-off-by: James Thompson <[email protected]>

* Update NATS.Client.JetStream.csproj

Signed-off-by: James Thompson <[email protected]>

* Force sdk to 8.0.0

Signed-off-by: James Thompson <[email protected]>

* Add newer stj for net 6

Signed-off-by: James Thompson <[email protected]>

---------

Signed-off-by: James Thompson <[email protected]>

* Add support for `Filter` and `Enrich` for OpenTelemetry activities (#859)

* Add support for `Filter` and `Enrich` for OpenTelemetry activities

* Make `internal` methods in `internal Telemetry` `public`

* Fix package versions and whatnot

* Remove `TracerProviderBuilderExtensions`

* Include `Deserialize` in the receive activity

* Revert back accidental change

* Add `ParentContext` to `NatsInstrumentationContext`

* Make `GetActivityContext` public to provide the ability to get context activity context

* Make preprocessor directive more accurate

* Revert .csproj formatting

* Move public artifacts out of the `Internal` namespace/folder

* Fix build script

---------

Co-authored-by: Ziya Suzen <[email protected]>

* Obsolete ReplyAsync method for NatsJsMsg (#839)

* Obsolete ReplyAsync method

* Obsolete ReplyAsync method on interface

* #851 Move Serialization Interface into Abstractions (#858)

* Tweaks

Signed-off-by: James Thompson <[email protected]>

* Add missing dependencies

Signed-off-by: James Thompson <[email protected]>

* switch to system.memory

Signed-off-by: James Thompson <[email protected]>

* Added missing using

Signed-off-by: James Thompson <[email protected]>

* Reduce csproj file contents

Signed-off-by: James Thompson <[email protected]>

---------

Signed-off-by: James Thompson <[email protected]>

* Release 2.7.0-preview.1 (#905)

* #851 Move Serialization Interface into Abstractions (#858)
* Obsolete ReplyAsync method for NatsJsMsg (#839)
* Add support for `Filter` and `Enrich` for OpenTelemetry activities (#859)
* #848 Tweak dependencies (#853)
* #863 Fix naming of consumer group attribute (#870)

* fix: `NatsInstrumentationOptions.Default` gets reset each time (#907)

* initialize `NatsInstrumentationOptions.Default` once

* `NatsInstrumentationContext.ActivityContext` doesn't need to be nullable

* no need for `GetActivityContext` on NatsJSMsg

* Release 2.7.0-preview.2 (#908)

* fix: `NatsInstrumentationOptions.Default` gets reset each time (#907)
* Also, fixes from main

* Fix build warnings (#912)

* fix: `NatsJSConsumer` never disposing receive activities (#911)

* Fix `NatsJSConsumer` never disposing receive activities

* Use `ActivityEndingMsgReader` to `NatsJSFetch` and `NatsJSOrderedConsume`

* Consolidate activity ending message readers into one class

* Run `dotnet format`

* Release 2.7.0-preview.3 (#922)

* fix: `NatsJSConsumer` never disposing receive activities (#911)
* Merge from main

* chore: rework NatsOpt.Default initialization (#921)

* chore: rework NatsOpt.Default initialization

* chore: removed unused using statement

* Fix kv ttl interface (#909)

KV TTL should only be allowed on Create and Purge

* Release 2.7.0-preview.4 (#931)

Fixes merged from main

* Release 2.7.0-preview.5 (#944)

Merge from main aligning with 2.6.8 release.

* Fix JetStream publish retry defaults (#939)

Decision to retry jetstream publish requests should be letft to the
application since it depends on the delivery and durability
requirements of their solution.

* Fix publish 503 test (#958)

With 2.7.x we have made the default to not re-publish on failure.

* Release 2.7.0-preview.6 (#956)

* Fix JetStream publish retry defaults (#939)
* Merge from main

* Release 2.7.0-preview.7 (#970)

Merged from main

* fix: handle 408 Requests Pending responses for fetch requests (#973)

* Handle 408 Requests Pending responses for fetch requests

* Remove redundant `Console.WriteLine` that was put there for testing

* Release 2.7.0-preview.8 (#986)

* fix: handle 408 Requests Pending responses for fetch requests (#973)
* (merge from main) Object store item size fix (#977)

* Fix Ad-Hoc JSON Serializer to use Default Options (#984)

* Fix connection state for consume (#959)

* Fix connection state for consume

* Enhance connection state handling with NatsConnectionFailedException

* Improve error handling for connection failures and add support for configurable 503 error thresholds in JetStream consumers

* Add tests for connection failure handling and configurable 503 error thresholds in JetStream consumers

* Fix format

* Fix test

* Update INatsJsConsumer to return INatsJsMsg (#1004)

---------

Signed-off-by: James Thompson <[email protected]>
Co-authored-by: James Thompson <[email protected]>
Co-authored-by: Arad Alvand <[email protected]>
Co-authored-by: Yeong Jong Lim <[email protected]>
Co-authored-by: regnrat <[email protected]>
mtmk added a commit that referenced this pull request Dec 19, 2025
@mtmk
Release 2.7.0
dd7902b 
* Replace `OperationCanceledException` with `NatsTimeoutException` (#1022)
* Replace deprecated IndexRange package with Microsoft.Bcl.Memory to solve possible dependency conflicts (for netFramework/netStandard2.0) (#1009)
* PeerInfo.Lag is wrong type (#1021)
* (Merge Branch) Release 2.7 (#874)
  * Update INatsJsConsumer to return INatsJsMsg (#1004)
  * Fix connection state for consume (#959)
  * Fix Ad-Hoc JSON Serializer to use Default Options (#984)
  * fix: handle 408 Requests Pending responses for fetch requests (#973)
  * Fix publish 503 test (#958)
  * Fix JetStream publish retry defaults (#939)
  * Fix kv ttl interface (#909)
  * chore: rework NatsOpt.Default initialization (#921)
  * fix: `NatsJSConsumer` never disposing receive activities (#911)
  * Fix build warnings (#912)
  * fix: `NatsInstrumentationOptions.Default` gets reset each time (#907)
  * #851 Move Serialization Interface into Abstractions (#858)
  * Obsolete ReplyAsync method for NatsJsMsg (#839)
  * Add support for `Filter` and `Enrich` for OpenTelemetry activities (#859)
  * #848 Tweak dependencies (#853)
  * #863 Fix naming of consumer group attribute (#870)
@mtmk mtmk mentioned this pull request Dec 19, 2025
Merged
mtmk added a commit that referenced this pull request Dec 19, 2025
@mtmk
Release 2.7.0 (#1024)
872fb95 
* Replace `OperationCanceledException` with `NatsTimeoutException` (#1022)
* Replace deprecated IndexRange package with Microsoft.Bcl.Memory to solve possible dependency conflicts (for netFramework/netStandard2.0) (#1009)
* PeerInfo.Lag is wrong type (#1021)
* (Merge Branch) Release 2.7 (#874)
  * Update INatsJsConsumer to return INatsJsMsg (#1004)
  * Fix connection state for consume (#959)
  * Fix Ad-Hoc JSON Serializer to use Default Options (#984)
  * fix: handle 408 Requests Pending responses for fetch requests (#973)
  * Fix publish 503 test (#958)
  * Fix JetStream publish retry defaults (#939)
  * Fix kv ttl interface (#909)
  * chore: rework NatsOpt.Default initialization (#921)
  * fix: `NatsJSConsumer` never disposing receive activities (#911)
  * Fix build warnings (#912)
  * fix: `NatsInstrumentationOptions.Default` gets reset each time (#907)
  * #851 Move Serialization Interface into Abstractions (#858)
  * Obsolete ReplyAsync method for NatsJsMsg (#839)
  * Add support for `Filter` and `Enrich` for OpenTelemetry activities (#859)
  * #848 Tweak dependencies (#853)
  * #863 Fix naming of consumer group attribute (#870)
@dependabot dependabot bot mentioned this pull request Dec 22, 2025
Closed
@dependabot dependabot bot mentioned this pull request Jan 12, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtmk mtmk mtmk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.7

Development

Successfully merging this pull request may close these issues.

Optimise dependencies based on framework

2 participants

@thompson-tomo @mtmk