Fix pending message reset logic in NatsJSConsume #930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request improves the pending message reset logic in the NatsJSConsume class by replacing duplicate manual counter reset code with a dedicated method call. The change addresses issue #927 related to proper handling of pending message counters during reconnection scenarios.
- Replaces manual pending counter resets with calls to existing
ResetPending()method - Adds test coverage for ephemeral consumer reconnection behavior to prevent flooding the server with pull requests
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/NATS.Client.JetStream/Internal/NatsJSConsume.cs | Refactors duplicate pending counter reset logic to use ResetPending() method |
| tests/NATS.Client.JetStream.Tests/ConsumerConsumeTest.cs | Adds test to verify proper pending reset behavior during server reconnection |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mtmk
added a commit
that referenced
this pull request
Aug 21, 2025
fess9999
pushed a commit
to TouchPlusIE/nats.net
that referenced
this pull request
Sep 10, 2025
* Fix pending message reset logic in NatsJSConsume * Add consumer test for pending reset on 503
fess9999
pushed a commit
to TouchPlusIE/nats.net
that referenced
this pull request
Sep 10, 2025
* Fix pending message reset logic in NatsJSConsume (nats-io#930) * Fix CommandWriter.cs dispose (nats-io#926)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors how pending message and byte counters are reset in the
ReceiveInternalAsyncmethod ofNatsJSConsume. Instead of manually resetting these counters within a lock block, the code now calls a dedicated method,ResetPending, which improves code readability and maintainability and does the right thing instead of setting them to zero.