fix: Do not transfer ownership of chunk buffer (issue #917)

[MiloszKrajewski]

ObjectStore.PutAsync was transferring ownership of memory buffer.
Memory buffer was returned to the pool on serialization. Everything was going smooth until performance degradation. In such case retries were needed using same memory buffer which was already returned to the pool so it might have contain some other data.

This PR keeps ownership for the whole upload process and does not transfer it down to serializer.

You could argue that using var memoryOwner may be moved inside while loop, but it will just increase pool churn. There are no other awaits after publishing so this buffer would return to pool for only few CPU cycles.

• fixes NATS.Client.ObjectStore.NatsObjException: SHA-256 digest mismatch #917

[mtmk]

thanks again @MiloszKrajewski! looks good. just need commit gpg signing. you might have to force push after (since all commits need to be signed),which is fine.

[MiloszKrajewski]

thanks again @MiloszKrajewski! looks good. just need commit gpg signing. you might have to force push after (since all commits need to be signed),which is fine.

Phew, it took me a while. Apparently when your signature uses CRLF git tells you that signature file does not exist. Another deep debugging ;-)

[MiloszKrajewski]

Any way to get this released even as preview?
Currently we have very dodgy and convoluted way to include this fix in out binaries.

🙏

[mtmk]

Any way to get this released even as preview? Currently we have very dodgy and convoluted way to include this fix in out binaries.

🙏

of course, we should have a new release sometime today 🤞

[mtmk]

LGTM thanks @MiloszKrajewski great fix also a better design

[mtmk]

@MiloszKrajewski your fix is just released in https://github.com/nats-io/nats.net/releases/tag/v2.6.8

thank you 👍