Fix Object Store Rename #954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtmk
added a commit
that referenced
this pull request
Sep 17, 2025
Merged
mtmk
added a commit
that referenced
this pull request
Sep 17, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the handling of object metadata renaming in the NATS Object Store by ensuring that when an object's name is changed, the old metadata record is properly purged. It also adds a comprehensive test to verify this behavior.
Object metadata renaming and cleanup:
UpdateMetaAsyncinNatsObjStore.csto purge the old metadata record if the object's name is changed, preventing stale metadata from lingering after a rename.Testing and verification:
Rename_object_should_perge_old_named_metainObjectStoreTest.csto verify that renaming an object correctly purges the old metadata, updates the stream as expected, and ensures the object can only be accessed by the new name.Related