Add persist mode support #964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the PersistMode property to JetStream StreamConfig, enabling users to configure different persistence modes for streams (supported from NATS server v2.12+). The implementation includes proper serialization/deserialization handling and comprehensive test coverage.
- Introduces
StreamConfigPersistModeenum withDefaultandAsyncvalues - Adds
PersistModeproperty toStreamConfigclass with JSON serialization attributes - Updates JSON serializers to handle the new enum with snake_case conversion
- Includes tests for creation, retrieval, and update validation of persist mode settings
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| StreamConfigPersistMode.cs | Defines new enum for persist mode values |
| StreamConfig.cs | Adds PersistMode property with JSON serialization configuration |
| NatsJSJsonSerializer.cs | Updates enum converters to handle StreamConfigPersistMode serialization |
| ManageStreamTest.cs | Adds comprehensive test coverage for persist mode functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Change `PersistMode` to nullable and adjust serialization to exclude it when null. Add tests to confirm correct serialization/deserialization behaviors and align with server's behavior for handling default or absent values.
# Conflicts: # src/NATS.Client.JetStream/Models/StreamConfig.cs # tests/NATS.Client.JetStream.Tests/ManageStreamTest.cs
mtmk
added a commit
that referenced
this pull request
Oct 1, 2025
Merged
mtmk
added a commit
that referenced
this pull request
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the new
PersistModeproperty to the JetStreamStreamConfig, enabling users to specify different persistence modes for streams (supported from server v2.12). It introduces a new enum for persist modes, updates serialization/deserialization logic, and adds comprehensive tests to ensure correct behavior and error handling.PersistMode property support in StreamConfig:
PersistModeproperty of typeStreamConfigPersistModeto theStreamConfigclass, allowing configuration of stream persistence mode. This property is serialized as"persist_mode"and defaults toDefault.StreamConfigPersistModeenum with valuesDefaultandAsync.Serialization and deserialization updates:
StreamConfigPersistModeusing snake_case string values for both reading and writing. [1] [2] [3]Testing enhancements:
PersistModeproperty is correctly set, persisted, and validated on stream creation, and that updating the property results in the expected server error.