Reduce closure allocations #988
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving timer initialization and timeout handling in the
NatsSubBaseclass, and introduces a new microbenchmark for subscription construction. The main changes ensure that timers are only created when necessary and initialized with explicit parameters, and that timeouts default toTimeSpan.Zeroinstead of the default struct value. Additionally, the code now uses static delegates for timer callbacks to reduce allocations.Timeout and Timer Initialization Improvements:
_idleTimeout,_startUpTimeout, and_timeoutto useTimeSpan.Zeroinstead of the default struct value, ensuring more explicit and predictable timeout behavior.TimeSpan.Zeroinstead ofdefaultand to initialize timers with explicit state and callback parameters. This reduces GC pressure and ensures timers are only allocated when needed. [1] [2]Delegate and Callback Optimization:
Benchmarking:
SubscribeCtorto measure the performance of constructing newNatsSub<int>instances, aiding in performance testing and analysis.Benchmark SubscribeCtor.NewNatsSub
this PR:
main: