feat: swift package manager

[EchoEllet]

Overview

Adds support for SPM following the Flutter instructions.

• I read the Contributor Guide and followed the process outlined there for submitting PRs.

Related Issues

• Fix Add Swift Package Manager Support #241
• Partial fix of Support for Swift Package Manager singerdmx/flutter-quill#2394

[EchoEllet]

A quick review of the changes.

[EchoEllet]

nit: I have tested both CocoaPods and SPM within the example (turning on and off SPM) but it might be a good idea to automate this check in CI, We often don't need this since this one package and it would complicate the process.

[EchoEllet]

Collection literals should not have trailing commas
.process("PrivacyInfo.xcprivacy"),

This doesn't apply to Swift code (false positive).

[natsuk4ze]

Thank you for your contribution @EchoEllet !

This doesn't apply to Swift code (false positive).

Can you follow the rules?

[EchoEllet]

Can you follow the rules?

Single quotes (') are not used for string literals in Swift:

// This won't compile
.process('PrivacyInfo.xcprivacy'),

This warning is in the file Package.swift, it's not possible to use 'PrivacyInfo.xcprivacy' instead of "PrivacyInfo.xcprivacy".

[natsuk4ze]

I think the warning is for trailing comma @EchoEllet

[EchoEllet]

Files should have a single trailing newline

I have added a single trailing newline to the file Package.swift though it still fails.

[natsuk4ze]

we need the new line here

[EchoEllet]

[EchoEllet]

Running wc -l darwin/gal/Package.swift outputs 25 when it's 26 lines in the code editor and actual file, it's likely a configuration issue in Git (related to line-endings) or the editor in my local machine. I added another line from my end so it appears only one empty line at the end from remote.

[natsuk4ze]

@EchoEllet Oh no. Please do not stop adding Privacy Manifest. It is fine without it, but adding an empty Privacy Manifest is a better choice.

Can you revert 83f710d?

[EchoEllet]

but adding an empty Privacy Manifest is a better choice.

By empty, I think they meant empty values, they said Only shared_preferences has a non-empty manifest, (see PrivacyInfo.xcprivacy of shared_preferences). All the other plugins including image_picker has the same template with default values.

[natsuk4ze]

I updated the Codacy setting for ignore this issue.