Skip to content

Conversation

@nicolad
Copy link
Member

@nicolad nicolad commented Nov 1, 2025

Pull Request

NautilusTrader prioritizes correctness and reliability, please follow existing patterns for validation and testing.

  • I have reviewed the CONTRIBUTING.md and followed the established practices

Summary

Related Issues/PRs

Related to #3151

Type of change

  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Improvement (non-breaking)
  • Breaking change (impacts existing behavior)
  • Documentation update
  • Maintenance / chore

Breaking change details (if applicable)

Documentation

  • Documentation changes follow the style guide (docs/developer_guide/docs.md)

Release notes

  • I added a concise entry to RELEASES.md that follows the existing conventions (when applicable)

Testing

Ensure new or changed logic is covered by tests.

  • Affected code paths are already covered by the test suite
  • I added/updated tests to cover new or changed logic

@nicolad nicolad requested a review from cjdsellers November 1, 2025 19:15
@nicolad nicolad self-assigned this Nov 2, 2025
@nicolad nicolad marked this pull request as ready for review November 2, 2025 09:36
@cjdsellers cjdsellers changed the title Add dYdX gRPC transaction signing Implement transaction signer and builder using cosmrs for Cosmos SDK integration. Add initial dYdX crate Nov 3, 2025
Copy link
Member

@cjdsellers cjdsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nicolad, establishing a good base here.

We'll just need to determine how to handle dydx-proto (TBD).

Copy link
Member

@cjdsellers cjdsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nicolad great foundation forming here already!

@nicolad nicolad force-pushed the 2981-dydx-1 branch 2 times, most recently from 0706476 to 4e86924 Compare November 4, 2025 16:51
Copy link

@SarunasSS SarunasSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far seems to be a direct port of how the python works, so so far so good.

@nicolad nicolad requested a review from SarunasSS November 5, 2025 08:15
Copy link
Member

@cjdsellers cjdsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@cjdsellers cjdsellers merged commit 6c34aa7 into develop Nov 5, 2025
17 checks passed
@cjdsellers cjdsellers deleted the 2981-dydx-1 branch November 5, 2025 09:16
@nicolad nicolad added rust Relating to the Rust core adapter Nautilus integration with external systems labels Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adapter Nautilus integration with external systems rust Relating to the Rust core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants