This repository was archived by the owner on Sep 24, 2025. It is now read-only.
Move cache of recently used agents to distribution map #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songeunwoo
previously approved these changes
Oct 8, 2020
junoyoon
reviewed
Oct 8, 2020
ngrinder-controller/src/main/java/org/ngrinder/infra/config/DynamicCacheConfig.java
Outdated
Show resolved
Hide resolved
|
Please describe the problem when you fix the bugs. |
|
We are using a hazelcast dist map to store the data of recently used agents. Simply the expire time that I set is not being applied. (T_T) |
donggyu04
force-pushed
the
feature/move-recent-agent-cache-to-dist-map
branch
from
6b49a02 to
c565dbc
Compare
junoyoon
reviewed
Oct 8, 2020
| cm.addDistMap(DIST_MAP_NAME_SAMPLING, 15); | ||
| cm.addDistMap(DIST_MAP_NAME_MONITORING, 15); | ||
| cm.addDistMap(DIST_MAP_NAME_AGENT, 10); | ||
| cm.addDistMap(DIST_MAP_CACHE_RECENTLY_USED_AGENTS, 1 * DAY); |
There was a problem hiding this comment.
Could u rename all const here?
I think it's not consistent b/w local and remote cache...
For example, I think the following const is better.
- DIST_CACHE_SAMPLING
- DIST_CACHE_RECENTLY_USED_AGENTS
- LOCAL_CACHE_USERS
Please fix them by separate commit.
songeunwoo
approved these changes
Oct 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move cache of recently used agents to distribution map.