Attach @SuppressWarnings

ngrinder-controller/src/main/java/org/ngrinder/agent/controller/AgentManagerApiController.java

@@ -40,6 +40,7 @@
 /**
  * @since 3.5.0
  */
+@SuppressWarnings("unused")
 @RestController
 @RequestMapping("/agent/api")
 @PreAuthorize("hasAnyRole('A', 'S')")

ngrinder-controller/src/main/java/org/ngrinder/agent/controller/AgentManagerController.java

@@ -26,6 +26,7 @@
  *
  * @since 3.1
  */
+@SuppressWarnings("unused")
 @Controller
 @RequestMapping("/agent")
 @GlobalControllerModel

ngrinder-controller/src/main/java/org/ngrinder/agent/controller/MonitorDownloadController.java

@@ -63,6 +63,7 @@ public void download(@PathVariable String fileName, HttpServletResponse response
 	/**
 	 * Download monitor.
 	 */
+	@SuppressWarnings("SpringMVCViewInspection")
 	@GetMapping("")
 	public String download(ModelMap model) {
 		try {

ngrinder-controller/src/main/java/org/ngrinder/agent/model/Connection.java

@@ -6,6 +6,7 @@
 import javax.persistence.Entity;
 import javax.persistence.Table;
 
+@SuppressWarnings("JpaDataSourceORMInspection")
 @Getter
 @Setter
 @ToString

ngrinder-controller/src/main/java/org/ngrinder/agent/service/AgentService.java

@@ -527,7 +527,7 @@ public void update(Map<AgentIdentity, AgentProcessControlImplementation.AgentSta
 
 		for (AgentProcessControlImplementation.AgentStatus status : agentMap.values()) {
 			AgentControllerIdentityImplementation agentIdentity = (AgentControllerIdentityImplementation) status.getAgentIdentity();
-			AgentInfo agentInfo = agentInfoStore.getAgentInfo(createKey(agentIdentity));
+			AgentInfo agentInfo = agentInfoStore.getAgentInfo(createKey(requireNonNull(agentIdentity)));
 			// check new agent
 			if (agentInfo == null) {
 				agentInfo = new AgentInfo();

ngrinder-controller/src/main/java/org/ngrinder/common/constant/ControllerConstants.java

@@ -18,6 +18,7 @@
  *
  * @since 3.0
  */
+@SuppressWarnings("unused")
 public interface ControllerConstants {
 
 	String DEFAULT_PACKAGE_NAME = "org.ngrinder";

ngrinder-controller/src/main/java/org/ngrinder/common/constant/WebConstants.java

@@ -18,6 +18,7 @@
  *
  * @since 3.0
  */
+@SuppressWarnings("unused")
 public interface WebConstants {
 
 	String JSON_SUCCESS = "success";

ngrinder-controller/src/main/java/org/ngrinder/common/model/Home.java

@@ -1,4 +1,4 @@
-/* 
+/*
  * Licensed under the Apache License, Version 2.0 (the "License");
  *  you may not use this file except in compliance with the License.
  *  You may obtain a copy of the License at
@@ -9,7 +9,7 @@
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
- * limitations under the License. 
+ * limitations under the License.
  */
 package org.ngrinder.common.model;
 
@@ -29,6 +29,7 @@
 import java.io.StringReader;
 import java.util.Properties;
 
+import static java.util.Objects.requireNonNull;
 import static org.ngrinder.common.util.ExceptionUtils.processException;
 import static org.ngrinder.common.util.Preconditions.checkNotNull;
 
@@ -105,7 +106,7 @@ public File getDirectory() {
 	public void copyFrom(Resource[] resources) {
 		try {
 			for (Resource resource : resources) {
-				File resourceFile = new File(directory, resource.getFilename());
+				File resourceFile = new File(directory, requireNonNull(resource.getFilename()));
 				if (!resourceFile.exists()) {
 					FileUtils.copyInputStreamToFile(resource.getInputStream(), new File(directory, resource.getFilename()));
 				} else {

ngrinder-controller/src/main/java/org/ngrinder/common/util/FileWatchdog.java

@@ -5,9 +5,9 @@
  * The ASF licenses this file to You under the Apache License, Version 2.0
  * (the "License"); you may not use this file except in compliance with
  * the License.  You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -25,7 +25,7 @@
 /**
  * Check every now and then that a certain file has not changed. If it has, then
  * call the {@link #doOnChange} method.
- * 
+ *
  * @since 3.1.1
  */
 public abstract class FileWatchdog extends Thread {
@@ -59,7 +59,7 @@ protected FileWatchdog(String filename) {
 
 	/**
 	 * Set the delay to observe between each check of the file changes.
-	 * 
+	 *
 	 * @param delay
 	 *            the frequency of file watch.
 	 */
@@ -100,6 +100,7 @@ protected void checkAndConfigure() {
 		}
 	}
 
+	@SuppressWarnings("BusyWait")
 	@Override
 	public void run() {
 		while (!interrupted && !isInterrupted()) {

ngrinder-controller/src/main/java/org/ngrinder/common/util/HttpContainerContext.java

@@ -1,4 +1,4 @@
-/* 
+/*
  * Licensed under the Apache License, Version 2.0 (the "License");
  *  you may not use this file except in compliance with the License.
  *  You may obtain a copy of the License at
@@ -9,7 +9,7 @@
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
- * limitations under the License. 
+ * limitations under the License.
  */
 package org.ngrinder.common.util;
 
@@ -21,6 +21,7 @@
 
 import javax.servlet.http.HttpServletRequest;
 
+import static java.util.Objects.requireNonNull;
 import static org.ngrinder.common.constant.ControllerConstants.PROP_CONTROLLER_URL;
 import static org.ngrinder.common.util.TypeConvertUtils.cast;
 
@@ -58,7 +59,7 @@ public String getCurrentContextUrlFromUserRequest() {
 
 		// if empty
 		HttpServletRequest request = cast(RequestContextHolder.currentRequestAttributes().resolveReference("request"));
-		int serverPort = request.getServerPort();
+		int serverPort = requireNonNull(request).getServerPort();
 		// If it's http default port it will ignore the port part.
 		// However, if ngrinder is provided in HTTPS.. it can be a problem.
 		// FIXME : Later fix above.
@@ -74,6 +75,6 @@ public String getCurrentContextUrlFromUserRequest() {
 	public boolean isUnixUser() {
 		SecurityContextHolderAwareRequestWrapper request = cast(RequestContextHolder.currentRequestAttributes()
 				.resolveReference("request"));
-		return !StringUtils.containsIgnoreCase(request.getHeader("User-Agent"), "Win");
+		return !StringUtils.containsIgnoreCase(requireNonNull(request).getHeader("User-Agent"), "Win");
 	}
 }

ngrinder-controller/src/main/java/org/ngrinder/home/controller/HomeController.java

@@ -45,6 +45,7 @@
  *
  * @since 3.0
  */
+@SuppressWarnings("SpringMVCViewInspection")
 @Slf4j
 @Controller
 @GlobalControllerModel

ngrinder-controller/src/main/java/org/ngrinder/infra/config/ApplicationListenerBean.java

@@ -1,4 +1,4 @@
-/* 
+/*
  * Licensed under the Apache License, Version 2.0 (the "License");
  *  you may not use this file except in compliance with the License.
  *  You may obtain a copy of the License at
@@ -9,7 +9,7 @@
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
- * limitations under the License. 
+ * limitations under the License.
  */
 
 package org.ngrinder.infra.config;
@@ -18,15 +18,16 @@
 import org.ngrinder.common.model.Home;
 import org.springframework.context.ApplicationListener;
 import org.springframework.context.event.ContextRefreshedEvent;
+import org.springframework.lang.NonNull;
 import org.springframework.stereotype.Service;
 
 import lombok.RequiredArgsConstructor;
 
 /**
  * Application life-cycle event listener.
- * 
+ *
  * This class is used to clean up the several locks.
- * 
+ *
  * @since 3.1
  */
 @Service
@@ -35,6 +36,7 @@ public class ApplicationListenerBean implements ApplicationListener<ContextRefre
 
 	private final Config config;
 
+	@SuppressWarnings("NullableProblems")
 	@Override
 	public void onApplicationEvent(ContextRefreshedEvent event) {
 		Home exHome = config.getExHome();

ngrinder-controller/src/main/java/org/ngrinder/infra/config/Config.java

@@ -212,6 +212,7 @@ public int getMonitorPort() {
 	 *
 	 * @return true if enabled.
 	 */
+	@SuppressWarnings("unused")
 	public boolean isUsageReportEnabled() {
 		return getControllerProperties().getPropertyBoolean(PROP_CONTROLLER_USAGE_REPORT);
 	}
@@ -295,6 +296,7 @@ public static String getUserHome() {
 			CoreLogger.LOGGER.warn("    '" + userHomeFromProperty + "' is accepted.");
 		}
 		String userHome = StringUtils.defaultIfEmpty(userHomeFromProperty, userHomeFromEnv);
+
 		if (isEmpty(userHome)) {
 			userHome = System.getProperty("user.home") + File.separator + NGRINDER_DEFAULT_FOLDER;
 		} else if (StringUtils.startsWith(userHome, "~" + File.separator)) {
@@ -650,12 +652,12 @@ public String getCurrentIP() {
 		}
 	}
 
-
 	/**
 	 * Check if the current ngrinder instance is hidden instance from the cluster.
 	 *
 	 * @return true if hidden.
 	 */
+	@SuppressWarnings("unused")
 	public boolean isInvisibleRegion() {
 		return getClusterProperties().getPropertyBoolean(PROP_CLUSTER_HIDDEN_REGION);
 	}

ngrinder-controller/src/main/java/org/ngrinder/infra/config/DynamicCacheConfig.java

@@ -177,6 +177,7 @@ void addDistMap(String cacheName, int timeout) {
 			hazelcastCacheConfigs.put(cacheName, mapConfig);
 		}
 
+		@SuppressWarnings("SameParameterValue")
 		void addDistCache(String cacheName, int timeout, int count) {
 			MapConfig mapConfig = createDistMapConfig(cacheName, timeout);
 

ngrinder-controller/src/main/java/org/ngrinder/infra/config/UserDefinedMessageSource.java

@@ -118,6 +118,7 @@ private Map<String, String> getMessageMap(String locale) {
 			.collect(Collectors.toMap(entry -> entry.getKey().code, entry -> entry.getValue().toPattern()));
 	}
 
+	@SuppressWarnings("NullableProblems")
 	@Override
 	protected MessageFormat resolveCode(String code, Locale locale) {
 		MessageFormat resolved = langMessageMap.get(new LocaleAndCode(locale.getLanguage(), code));

ngrinder-controller/src/main/java/org/ngrinder/infra/interceptor/DefaultSuccessJsonInterceptor.java

@@ -23,6 +23,7 @@ public class DefaultSuccessJsonInterceptor implements HandlerInterceptor, WebCon
 	@Autowired
 	private ObjectMapper objectMapper;
 
+	@SuppressWarnings("NullableProblems")
 	@Override
 	public void postHandle(HttpServletRequest request, HttpServletResponse response, Object handler, ModelAndView modelAndView) throws Exception {
 		if (modelAndView == null && !response.isCommitted() &&

ngrinder-controller/src/main/java/org/ngrinder/infra/spring/ApiExceptionHandlerResolver.java

@@ -68,6 +68,7 @@ public int getOrder() {
 	 * javax.servlet.http.HttpServletResponse, java.lang.Object,
 	 * java.lang.Exception)
 	 */
+	@SuppressWarnings("NullableProblems")
 	@Override
 	public ModelAndView resolveException(HttpServletRequest request, HttpServletResponse response, Object handler, Exception ex) {
 		if (!(handler instanceof HandlerMethod)) {

ngrinder-controller/src/main/java/org/ngrinder/infra/spring/RemainedPathMethodArgumentResolver.java

@@ -24,6 +24,8 @@
 import org.springframework.web.method.support.HandlerMethodArgumentResolver;
 import org.springframework.web.method.support.ModelAndViewContainer;
 
+import static java.util.Objects.requireNonNull;
+
 /**
  * Custom argument resolver to catch the unresolved remaining path.
  *
@@ -69,7 +71,7 @@ public Object resolveArgument(MethodParameter parameter, ModelAndViewContainer m
 		AntPathMatcher pathMatcher = new AntPathMatcher();
 		RequestMapping requestMappingOnMethod = parameter.getMethodAnnotation(RequestMapping.class);
 		RequestMapping requestMappingOnClass = getDeclaringClassRequestMapping(parameter);
-		String combine = pathMatcher.combine(requestMappingOnClass.value()[0], requestMappingOnMethod.value()[0]);
+		String combine = pathMatcher.combine(requestMappingOnClass.value()[0], requireNonNull(requestMappingOnMethod).value()[0]);
 		String path = ((ServletWebRequest) webRequest).getRequest().getRequestURI().substring(webRequest.getContextPath().length());
 		return PathUtils.removePrependedSlash(pathMatcher.extractPathWithinPattern(combine, EncodingUtils.decodePathWithUTF8(path)));
 	}

ngrinder-controller/src/main/java/org/ngrinder/infra/spring/SpringContext.java

@@ -1,4 +1,4 @@
-/* 
+/*
  * Licensed under the Apache License, Version 2.0 (the "License");
  *  you may not use this file except in compliance with the License.
  *  You may obtain a copy of the License at
@@ -9,7 +9,7 @@
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
- * limitations under the License. 
+ * limitations under the License.
  */
 package org.ngrinder.infra.spring;
 
@@ -40,6 +40,7 @@ public boolean isAuthenticationContext() {
 	 * @return always false.
 	 * @see MockSpringContext
 	 */
+	@SuppressWarnings("JavadocReference")
 	public boolean isUnitTestContext() {
 		return false;
 	}

ngrinder-controller/src/main/java/org/ngrinder/infra/spring/UserHandlerMethodArgumentResolver.java

@@ -48,6 +48,7 @@ public boolean supportsParameter(MethodParameter parameter) {
 		return parameter.getParameterIndex() == 0 && parameter.getParameterType().equals(User.class);
 	}
 
+	@SuppressWarnings("NullableProblems")
 	@Override
 	public Object resolveArgument(MethodParameter parameter, ModelAndViewContainer mavContainer,
 			NativeWebRequest webRequest, WebDataBinderFactory binderFactory) {

ngrinder-controller/src/main/java/org/ngrinder/infra/spring/listener/ApplicationPreparedListener.java

@@ -13,6 +13,7 @@
  * */
 public class ApplicationPreparedListener implements ApplicationListener<ApplicationPreparedEvent> {
 
+	@SuppressWarnings("NullableProblems")
 	@Override
 	public void onApplicationEvent(ApplicationPreparedEvent event) {
 		removeCacheProviderExceptCaffeineCacheProvider();

ngrinder-controller/src/main/java/org/ngrinder/infra/webhook/model/WebhookActivation.java

@@ -36,6 +36,7 @@
  *
  * @since 3.5.2
  */
+@SuppressWarnings("JpaDataSourceORMInspection")
 @Getter
 @Setter
 @Entity

ngrinder-controller/src/main/java/org/ngrinder/infra/webhook/model/WebhookConfig.java

@@ -36,6 +36,7 @@
  *
  * @since 3.5.2
  */
+@SuppressWarnings("JpaDataSourceORMInspection")
 @Getter
 @Setter
 @Entity

ngrinder-controller/src/main/java/org/ngrinder/infra/webhook/repository/WebhookActivationRepository.java

@@ -34,6 +34,7 @@
  */
 public interface WebhookActivationRepository extends JpaRepository<WebhookActivation, Long>, JpaSpecificationExecutor<WebhookActivation> {
 
+	@SuppressWarnings("NullableProblems")
 	@Override
 	Page<WebhookActivation> findAll(Specification<WebhookActivation> spec, Pageable pageable);
 }

ngrinder-controller/src/main/java/org/ngrinder/infra/webhook/service/NGrinderWebhookClient.java

@@ -42,6 +42,7 @@ public class NGrinderWebhookClient {
 
 	private final WebClient webClient;
 
+	@SuppressWarnings("BlockingMethodInNonBlockingContext")
 	Mono<ResponseEntity<String>> post(String url,
 									  MediaType mediaType,
 									  Map<String, Object> payLoad) {

ngrinder-controller/src/main/java/org/ngrinder/operation/cotroller/AnnouncementController.java

@@ -29,6 +29,7 @@
 @PreAuthorize("hasAnyRole('A', 'S')")
 public class AnnouncementController {
 
+	@SuppressWarnings("SpringMVCViewInspection")
 	@GetMapping("")
 	public String open() {
 		return "app";

ngrinder-controller/src/main/java/org/ngrinder/operation/cotroller/ScriptConsoleController.java

@@ -27,6 +27,7 @@
 @PreAuthorize("hasAnyRole('A')")
 public class ScriptConsoleController {
 
+	@SuppressWarnings("SpringMVCViewInspection")
 	@GetMapping({"", "/"})
 	public String scriptConsole() {
 		return "app";

ngrinder-controller/src/main/java/org/ngrinder/operation/cotroller/SystemConfigController.java

@@ -30,6 +30,7 @@
 @PreAuthorize("hasAnyRole('A')")
 public class SystemConfigController {
 
+	@SuppressWarnings("SpringMVCViewInspection")
 	@GetMapping("")
 	public String systemConfig() {
 		return "app";