[Linting] Eslint v9 dependency upgrades #3248
Merged
+38
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
Storybook demo082663c03 | 91 komponenter | 144 stories |
@navikt/core/react/src/util/hooks/descendants/useDescendant.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
I think we can live without |
HalvorHaugan
previously approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looked up all our eslint-packages and checked their compat with Eslint v9.
Besides
eslint-plugin-storybookandeslint-plugin-testing-libraryit looks like every other package now supports it. Could consider removingeslint-plugin-testing-libraryif@vitest/eslint-pluginhandles most of it anywaysuseDescendant update
Because of this change i had to update the component-names
facebook/react#25162
Component Checklist 📝
@navikt/core/css/config/_mappings.js)@navikt/core/css/tokens.json)@navikt/aksel-stylelint/src/deprecations.ts)@navikt/core/react/src/index.tsand@navikt/core/react/package.json)@navikt/core/css/index.css)<Component>: <gitmoji?> <Text>.E.g. "Button: ✨ Add feature xyz.")