Skip to content

Conversation

@0xc0de4c0ffee
Copy link

Draft implementation for NIP-XX: Nostr-specific Private Key from Deterministic Wallet Signature (Sign-in-With-X) nostr-protocol/nips#268

@fiatjaf
Copy link
Collaborator

fiatjaf commented Feb 25, 2023

I don't understand this and am not convinced it is a good thing.

@sshmatrix sshmatrix deleted the sign-in-with-x branch March 19, 2023 12:54
@sshmatrix sshmatrix restored the sign-in-with-x branch March 19, 2023 13:29
@sshmatrix
Copy link

Sorry, I made a mistake while housekeeping and deleted branch under PR. I have restored it. Apologies for the small mess up

@sshmatrix
Copy link

Hi @fiatjaf,

We have added better testing environment in Nostr Tools for the proposed implementation in NIP-XX: Sign-In-With-X document; the document itself has also improved significantly since last review. Testers should now be able to simply issue yarn jest nipxx.test.js to run the relevant tests. We'd appreciate a feedback on the updated codebase which now has preset ethereum wallet hooks.

We have also finished the Nostr client's frontend and the prototype can be accessed here: Dostr: Ethereum-flavoured Nostr Client. We have not yet hooked NIP-XX to it on the public URL since we'd love your feedback before we open this up to the public for use. The client itself can however already be used to access Nostr in usual ways. This client is a fork of Astral and we have polished it up a bit for better UI/UX.

P.S. We'll be requesting NIP identifier 60 or 111 on the PR#268 for NIP-XX.

Looking forward to hearing back from you on this PR!

@fiatjaf
Copy link
Collaborator

fiatjaf commented Mar 21, 2023

The implementation looks good enough, but I don't like it for strictly personal reasons. Maybe it should live in a separate library. As for the NIP, I will comment there.

@BilligsterUser
Copy link
Contributor

@fiatjaf Can we close this?

@0xc0de4c0ffee
Copy link
Author

Thanks for your time & feedback..

Closing this for now/ 🙏 🖖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants