nip44 updates #278
Merged
nip44 updates #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Wait, but the NIP proposal didn't involve a TLV! |
Contributor
Author
|
It does now |
staab
force-pushed
the
nip44
branch
3 times, most recently
from
a196c6d to
8948089
Compare
Contributor
Author
|
Ok, updated this, tests should be passing now. |
fiatjaf
reviewed
Aug 16, 2023
| } | ||
|
|
||
| const nonce = data.slice(1, 25) | ||
| const ciphertext = data.slice(25) |
Collaborator
There was a problem hiding this comment.
slice is bad because it copies, subarray doesn't copy, so it's faster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nostr-protocol/nips#715
Take two, this time using a custom TLV. Note: I've never used TLVs before, so a review to make sure it's correct and idiomatic would be appreciated.