Skip to content

Added service_slim #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ncave wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Added service_slim #2

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
04f389e
Added service_slim
ncave Nov 15, 2021
a0fda6a
Async ParseAndCheckProject by Alfonso
ncave Nov 15, 2021
6fbde12
Added ParseAndCheckFileInProject
ncave Nov 15, 2021
4a286cc
Add Compile to service_slim and pub-sub pattern
alfonsogarciacaro Dec 23, 2021
b1e57a9
Disable CheckInlineValueIsComplete for Fable (#10)
alfonsogarciacaro Jun 8, 2022
d19c1ff
Fixed merge issues
ncave Aug 26, 2022
d8ad160
Don't lose attributes of method parameters (#12)
alfonsogarciacaro Aug 29, 2022
d01db3d
Added Buildalyzer
ncave Apr 15, 2023
7aec03a
Fixed merge
ncave Oct 15, 2023
8a1f1ed
Add GetDependentFiles to slim service. (#14)
nojaf Oct 25, 2023
9ac0bd5
Find all transitive dependent files. (#15)
nojaf Nov 1, 2023
0686071
Correct algorithm to find dependent files. (#16)
nojaf Nov 1, 2023
b28c888
Fixed merge issues
ncave Nov 16, 2024
0632137
Fixed merge issues
ncave Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disable CheckInlineValueIsComplete for Fable (#10)
  • Loading branch information
@alfonsogarciacaro @ncave
alfonsogarciacaro authored and ncave committed Nov 21, 2025
commit b1e57a9b0d844f6f25c521d5f6b701637d2842f4
8 changes: 8 additions & 0 deletions src/Compiler/Optimize/Optimizer.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,10 +495,18 @@ let rec IsPartialExprVal x =
| ValValue (_, a)
| SizeValue (_, a) -> IsPartialExprVal a

#if FABLE_CLI
// Many Fable packages inline functions that access internal values to resolve generics, this is not an issue
// in "normal" Fable compilations but it raises errors when generating an assembly por precompilation. Disable
// for Fable as it's not an actual error (and if is, we assume it's already been raised during type chedking).
let CheckInlineValueIsComplete (_v: Val) _res =
()
#else
let CheckInlineValueIsComplete (v: Val) res =
if v.ShouldInline && IsPartialExprVal res then
errorR(Error(FSComp.SR.optValueMarkedInlineButIncomplete(v.DisplayName), v.Range))
//System.Diagnostics.Debug.Assert(false, sprintf "Break for incomplete inline value %s" v.DisplayName)
#endif

let check (vref: ValRef) (res: ValInfo) =
CheckInlineValueIsComplete vref.Deref res.ValExprInfo
Expand Down