Repository navigation
fix(runtime): surface skip reason in pinned 503 (#486) #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
fix(runtime): address review feedback on pinned 503 (#486)
- Extract `buildPinnedUnavailableErrorBody` helper so the null-reason state-desync branch can be unit-tested directly without standing up a full proxy. The helper is exported alongside a typed `PinnedUnavailableErrorBody` interface so external consumers can rely on a stable shape. - Tighten the end-to-end cooling-down assertion from a regex prefix to an exact equality check against `cooling-down:auth-failure`, the string set by `markAccountCoolingDown` in the test setup. Prevents silent contract drift on the cooldown reason format. - Add chooseAccount unit cases for the remaining pinned skip reasons flagged by review: `workspace-disabled` (all workspaces disabled) and `circuit-open` (failure threshold tripped via `recordFailure`). The suite now mirrors the full enumeration in `AccountManager.getAccountRuntimeSkipReason`. - Add direct unit coverage for `buildPinnedUnavailableErrorBody` over four shapes: empty map yields `reason: null` with no parenthetical in the message, populated map yields the reason plus the parenthetical, null `pinnedIndex` resolves to `pinnedAccountIndex: null` without throwing, and the full `account_skip_reasons` map is mirrored even when the pinned index has no entry of its own. Closes #486 partial: review feedback addressed; underlying state desync still needs reporter logs to root-cause.
- Loading branch information
commit 0bf756b48266ba50973e672ebef4b18ef1cf978b
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.