chore: add example SSR app built using Fastify #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joezo
changed the title
jackdclark
reviewed
Mar 7, 2019
Contributor
jackdclark
left a comment
jackdclark
left a comment
There was a problem hiding this comment.
Nice work @Joezo & @bmullan91
jackdclark
approved these changes
Mar 7, 2019
Contributor
jackdclark
left a comment
jackdclark
left a comment
There was a problem hiding this comment.
I'm sure we can make this look nicer, but it's a good foundation for local dev 👍
jackdclark
reviewed
Mar 7, 2019
| Download the example: | ||
|
|
||
| ```bash | ||
| curl https://codeload.github.com/nearform/graphql-hooks/tar.gz/master | tar -xz --strip=2 graphql-hooks-master/examples/fastify-ssr |
Contributor
There was a problem hiding this comment.
Contributor
Author
@jackdclark no it's beautiful as it is |
jackdclark
approved these changes
Mar 7, 2019
… Simpifies eslint and prettier config.
Co-Authored-By: Joezo <[email protected]>
jackdclark
previously approved these changes
Mar 7, 2019
jackdclark
approved these changes
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an example application that @bmullan91 had been using for local dev. It's very simple but showcases the different functional features nicely and will provide a good base for local development.
Uses lerna's
--hoistoption so that multiple packages use the same copy of react/react-domSimplifies the eslint and prettier setup.
Related issues
closes #69
Checklist