test: Add test for graphql-hooks-memcache #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackdclark
reviewed
Mar 11, 2019
Contributor
jackdclark
left a comment
jackdclark
left a comment
There was a problem hiding this comment.
Minor things, otherwise LGTM 👍
| it('lists all keys', () => { | ||
| cache.set('foo', 'bar') | ||
| cache.set('bar', 'baz') | ||
| expect(cache.keys().length).toEqual(2) |
Contributor
There was a problem hiding this comment.
Maybe assert the return value instead of or as well as the length?
Contributor
Author
There was a problem hiding this comment.
I don't know what the keys are though as their generated so can't assert on them.
Co-Authored-By: Joezo <[email protected]>
jackdclark
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a test for the memcache package.
Related issues
closes #93
Checklist