Skip to content

fix: throw an error if client.cache isn't provided in ssrMode #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jackdclark merged 2 commits into from
Mar 12, 2019
Merged

fix: throw an error if client.cache isn't provided in ssrMode #124

jackdclark merged 2 commits into from
Mar 12, 2019

Conversation

@jackdclark
Copy link
Contributor

@jackdclark jackdclark commented Mar 12, 2019

What does this PR do?

  • Makes graphql-hooks-ssr getInitialState throw if no cache is present in the client
  • Makes GraphQLClient throw if ssrMode is true & no cache is provided
  • Updates docs to reflect that client.cache is required in SSR mode
  • Adds regression tests

Related issues

Fixes #116

Checklist

  • I have checked the contributing document
  • I have added or updated any relevant documentation
  • I have added or updated any relevant tests

@jackdclark jackdclark requested review from Joezo and bmullan91 March 12, 2019 10:00
bmullan91
bmullan91 approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@bmullan91 bmullan91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@jackdclark jackdclark merged commit ece277d into master Mar 12, 2019
@jackdclark jackdclark deleted the fix/ssr-required-cache branch March 12, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@bmullan91 bmullan91 bmullan91 approved these changes

@Joezo Joezo Joezo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jackdclark @bmullan91 @Joezo