Skip to content

Unit tests for useQuery #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackdclark merged 4 commits into from
Feb 19, 2019
Merged

Unit tests for useQuery #24

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
38fc655
unit tests for useQuery
jackdclark Feb 19, 2019
aacbea6
mock useClientRequest & test calls
jackdclark Feb 19, 2019
f4a3a8c
additional test cases to cover useEffect conditional firing
jackdclark Feb 19, 2019
32663af
remove duplicate test
jackdclark Feb 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove duplicate test
  • Loading branch information
@jackdclark
jackdclark committed Feb 19, 2019
commit 32663afad138e3a25aa034c3b50a9a30c9b2c46a
6 changes: 0 additions & 6 deletions test/unit/useQuery.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,6 @@ describe('useQuery', () => {
expect(mockQueryReq).not.toHaveBeenCalled();
});

it('does not send the query on mount if there is already data', () => {
mockState.error = true;
testHook(() => useQuery(TEST_QUERY), { wrapper: Wrapper });
expect(mockQueryReq).not.toHaveBeenCalled();
});

it('does not send the query on mount if there is an error', () => {
mockState.error = true;
testHook(() => useQuery(TEST_QUERY), { wrapper: Wrapper });
Expand Down