-
Notifications
You must be signed in to change notification settings - Fork 91
Pagination #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Pagination #44
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a04f137
pagination with useQuery fetchMore
jackdclark 67f87ee
fetchMore pagination util with result updater & override
jackdclark b4298d6
move updateResult into options
jackdclark 7c61910
remove unnecessary default param
jackdclark eb5116f
update useQuery tests
jackdclark 6fa845a
update & add tests for useClientRequest
jackdclark 6a020ca
update documentation for fetchMore & updateResult
jackdclark 46317a4
remove fetchMore in favour of declarative pagination
jackdclark f222040
update README & add pagination guide
jackdclark ab46bea
updateResult -> updateData
jackdclark 03ec998
updateResult -> updateData pagination example
jackdclark c51efb8
improve refetch documentation & add code comments
jackdclark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,12 +8,10 @@ const defaultOpts = { | |
| }; | ||
|
|
||
| module.exports = function useQuery(query, opts = {}) { | ||
| const allOpts = { ...defaultOpts, ...opts }; | ||
| const client = React.useContext(ClientContext); | ||
| const [calledDuringSSR, setCalledDuringSSR] = React.useState(false); | ||
| const [queryReq, state] = useClientRequest(query, { | ||
| ...defaultOpts, | ||
| ...opts | ||
| }); | ||
| const [queryReq, state] = useClientRequest(query, allOpts); | ||
|
|
||
| if (client.ssrMode && opts.ssr !== false && !calledDuringSSR) { | ||
| // result may already be in the cache from previous SSR iterations | ||
|
|
@@ -30,6 +28,10 @@ module.exports = function useQuery(query, opts = {}) { | |
|
|
||
| return { | ||
| ...state, | ||
| refetch: () => queryReq({ skipCache: true }) | ||
| refetch: () => queryReq({ skipCache: true }), | ||
| fetchMore: ({ variables, ...rest } = {}) => | ||
| // merge variables so they don't all have to be passed back in, | ||
| // just the ones that are changing | ||
| queryReq({ ...rest, variables: { ...allOpts.variables, ...variables } }) | ||
|
||
| }; | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,7 +24,7 @@ describe('useClientRequest', () => { | |
| get: jest.fn(), | ||
| set: jest.fn() | ||
| }, | ||
| request: jest.fn().mockResolvedValue({ some: 'data' }) | ||
| request: jest.fn().mockResolvedValue({ data: 'data' }) | ||
| }; | ||
| }); | ||
|
|
||
|
|
@@ -127,7 +127,7 @@ describe('useClientRequest', () => { | |
| { operationName: 'test', variables: { limit: 2 }, query: TEST_QUERY }, | ||
| { operationName: 'test', variables: { limit: 2 } } | ||
| ); | ||
| expect(state).toEqual({ cacheHit: false, loading: false, some: 'data' }); | ||
| expect(state).toEqual({ cacheHit: false, loading: false, data: 'data' }); | ||
| }); | ||
|
|
||
| it('calls request with revised options', async () => { | ||
|
|
@@ -181,7 +181,7 @@ describe('useClientRequest', () => { | |
| expect(state).toEqual({ | ||
| cacheHit: false, | ||
| loading: false, | ||
| some: 'data' | ||
| data: 'data' | ||
| }); | ||
| }); | ||
|
|
||
|
|
@@ -198,7 +198,7 @@ describe('useClientRequest', () => { | |
| expect(state).toEqual({ | ||
| cacheHit: false, | ||
| loading: false, | ||
| some: 'data' | ||
| data: 'data' | ||
| }); | ||
| }); | ||
|
|
||
|
|
@@ -212,7 +212,91 @@ describe('useClientRequest', () => { | |
| await fetchData(); | ||
|
|
||
| expect(mockClient.cache.set).toHaveBeenCalledWith('cacheKey', { | ||
| some: 'data' | ||
| data: 'data' | ||
| }); | ||
| }); | ||
|
|
||
| describe('options.updateRequest', () => { | ||
| it('is called with old & new data if the data has changed & the result is returned', async () => { | ||
| let fetchData, state; | ||
| const updateResultMock = jest.fn().mockReturnValue('merged data'); | ||
| testHook( | ||
| () => | ||
| ([fetchData, state] = useClientRequest(TEST_QUERY, { | ||
| variables: { limit: 10 }, | ||
| updateResult: updateResultMock | ||
| })), | ||
| { wrapper: Wrapper } | ||
| ); | ||
|
|
||
| // first fetch to populate state | ||
| await fetchData(); | ||
|
|
||
| mockClient.request.mockResolvedValueOnce({ data: 'new data' }); | ||
| await fetchData({ variables: { limit: 20 } }); | ||
|
|
||
| expect(updateResultMock).toHaveBeenCalledWith('data', 'new data'); | ||
| expect(state).toEqual({ | ||
| cacheHit: false, | ||
| data: 'merged data', | ||
| loading: false | ||
| }); | ||
| }); | ||
|
|
||
| it('is not called if there is no old data', async () => { | ||
| let fetchData; | ||
| const updateResultMock = jest.fn(); | ||
| testHook( | ||
| () => | ||
| ([fetchData] = useClientRequest(TEST_QUERY, { | ||
| variables: { limit: 10 }, | ||
| updateResult: updateResultMock | ||
| })), | ||
| { wrapper: Wrapper } | ||
| ); | ||
|
|
||
| await fetchData(); | ||
|
|
||
| expect(updateResultMock).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('is not called if there is no new data', async () => { | ||
| let fetchData; | ||
| const updateResultMock = jest.fn(); | ||
| testHook( | ||
| () => | ||
| ([fetchData] = useClientRequest(TEST_QUERY, { | ||
| variables: { limit: 10 }, | ||
| updateResult: updateResultMock | ||
| })), | ||
| { wrapper: Wrapper } | ||
| ); | ||
|
|
||
| await fetchData(); | ||
|
|
||
| mockClient.request.mockReturnValueOnce({ errors: ['on no!'] }); | ||
| await fetchData({ variables: { limit: 20 } }); | ||
|
|
||
| expect(updateResultMock).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('throws if updateResult is not a function', async () => { | ||
| let fetchData; | ||
| testHook( | ||
| () => | ||
| ([fetchData] = useClientRequest(TEST_QUERY, { | ||
| variables: { limit: 10 }, | ||
| updateResult: 'do I look like a function to you?' | ||
| })), | ||
| { wrapper: Wrapper } | ||
| ); | ||
|
|
||
| // first fetch to populate state | ||
| await fetchData(); | ||
|
|
||
| expect(fetchData({ variables: { limit: 20 } })).rejects.toThrow( | ||
| 'options.updateResult must be a function' | ||
| ); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👏 excellent tests |
||
| }); | ||
| }); | ||
| }); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the name is
updateResult, maybe we should pass the entire result? It might be useful for a developer to change / override the errors in some circumstances.useClientRequestwould then look something like:The pagination example
updateResult:It makes updating the data a bit more verbose, but the developer could write a wrapper if it was a really common usecase:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, passing the entire result back allows internal properties like
loading&errorto be changed, or new ones to be added which could be abused or cause tricky bugs. We're going to rename this toupdateDataas a better description of what it's doing & if we see a use case for changing / overriding errors in the future, we could always introduce anupdateErrorsoption.