-
Notifications
You must be signed in to change notification settings - Fork 91
Lerna #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lerna #78
Conversation
jh3y
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whether it's part of this PR or another, updated documentation referring to the overall repo structure and a quick "what lerna is/does" will be beneficial to contributors.
|
@allcontributors[bot] please add @jh3y for review |
|
I've put up a pull request to add @jh3y! 🎉 |
bmullan91
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a few things - overall this is looking good 😎
Questions:
- Will the renovate bot still work, or do we also need to reconfigure it?
- We're a few commits behind master. Maybe we should freeze master until this is merged, what you reckon?
Had this same thought. The docs suggest that it will just work with "Renovate discovers and processes all dependency files in a repository (e.g. supports monorepo architecture such as lerna or yarn workspaces)". Hard to confirm until we've merged though.
We should be up to date now, but worth freezing until this is in as it's fairly close now. |
bmullan91
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - great work @jackdclark + @Joezo 🙇
What does this PR do?
Introduces Lerna to optimise the workflow around managing
graphql-hooks,graphql-hooks-ssrandgraphql-hooks-memcache. Bringsgraphql-hooks-ssrandgraphql-hooks-memcacheinto this repo.Why?
Related issues
Resolves #40
Checklist