Skip to content

Conversation

@jackdclark
Copy link
Contributor

@jackdclark jackdclark commented Feb 28, 2019

What does this PR do?

Introduces Lerna to optimise the workflow around managing graphql-hooks, graphql-hooks-ssr and graphql-hooks-memcache. Brings graphql-hooks-ssr and graphql-hooks-memcache into this repo.

Why?

  • Reduces the duplication of dev environment setup across repos, utilising the same test suite & linting rules
  • Manage releases, raise issues, track dependencies, etc from one place
  • Adds foundation to more easily add example apps that rely on the local packages
  • Can add e2e tests that use all packages

Related issues

Resolves #40

Checklist

  • I have checked the contributing document
  • I have added or updated any relevant documentation
  • I have added or updated any relevant tests

@jackdclark jackdclark marked this pull request as ready for review March 4, 2019 11:38
@jackdclark jackdclark requested a review from bmullan91 March 4, 2019 12:54
jh3y
jh3y previously approved these changes Mar 4, 2019
Copy link
Contributor

@jh3y jh3y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether it's part of this PR or another, updated documentation referring to the overall repo structure and a quick "what lerna is/does" will be beneficial to contributors.

@Joezo
Copy link
Contributor

Joezo commented Mar 4, 2019

@allcontributors[bot] please add @jh3y for review

@allcontributors
Copy link
Contributor

@Joezo

I've put up a pull request to add @jh3y! 🎉

@Joezo Joezo requested a review from jh3y March 4, 2019 16:30
Copy link
Contributor

@bmullan91 bmullan91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few things - overall this is looking good 😎

Questions:

  • Will the renovate bot still work, or do we also need to reconfigure it?
  • We're a few commits behind master. Maybe we should freeze master until this is merged, what you reckon?

@jackdclark
Copy link
Contributor Author

@bmullan91

Will the renovate bot still work, or do we also need to reconfigure it?

Had this same thought. The docs suggest that it will just work with "Renovate discovers and processes all dependency files in a repository (e.g. supports monorepo architecture such as lerna or yarn workspaces)". Hard to confirm until we've merged though.

We're a few commits behind master. Maybe we should freeze master until this is merged, what you reckon?

We should be up to date now, but worth freezing until this is in as it's fairly close now.

@Joezo Joezo requested a review from bmullan91 March 5, 2019 11:10
Copy link
Contributor

@bmullan91 bmullan91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - great work @jackdclark + @Joezo 🙇

@jackdclark jackdclark merged commit fcca10a into master Mar 5, 2019
@jackdclark jackdclark deleted the lerna branch March 5, 2019 13:52
@jackdclark jackdclark mentioned this pull request Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants