Handle unmounting whilst request is in flight #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joezo
requested review from
bmullan91 and
jackdclark
and removed request for
bmullan91
jackdclark
previously approved these changes
Mar 6, 2019
|
|
||
| const fetchDataPromise = fetchData() | ||
| unmount() | ||
| await fetchDataPromise |
bmullan91
previously approved these changes
Mar 6, 2019
|
|
||
| const fetchDataPromise = fetchData() | ||
| unmount() | ||
| await fetchDataPromise |
Contributor
There was a problem hiding this comment.
In this test it should resolve the result, right? We can then add a test that after unmount it resolves undefined:
const fetchDataPromise = fetchData()
unmount()
const firstResult = await fetchDataPromise // <- expected actual result
const secondResult = await fetchData() // <- expected undefined
Contributor
Author
There was a problem hiding this comment.
I've added a test for that 👍
bmullan91
approved these changes
Mar 6, 2019
Joezo
added a commit
that referenced
this pull request
Mar 6, 2019
Prevents `fetchData` within `useClientRequest` from updating state when a request returns, if the component has unmounted. closes #54 - [x] I have checked the [contributing document](../blob/master/CONTRIBUTING.md) - [x] I have added or updated any relevant documentation - [x] I have added or updated any relevant tests
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prevents
fetchDatawithinuseClientRequestfrom updating state when a request returns, if the component has unmounted.Related issues
closes #54
Checklist