Skip to content

1448-Count Good Nodes in Binary Tree -- SWIFT #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2022
Merged

1448-Count Good Nodes in Binary Tree -- SWIFT #1229

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
533bf55
Added code for count good nodes in binary tree - swift
Oct 3, 2022
18a6f07
updated solution to be more concise
Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions swift/1448-Count-Good-Nodes-In-Binary-Tree.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
//
// 1448-Count-Good-Nodes-In-Binary-Tree.swift
// Question Link: https://leetcode.com/problems/count-good-nodes-in-binary-tree/
//

class Solution {
func goodNodes(_ root: TreeNode?) -> Int {
guard let root = root else { return 0 }
return helper(root, Int.min)
}

func helper(_ root: TreeNode?, _ lastVal: Int) -> Int {
guard let root = root else { return 0 }

Copy link
Collaborator

@dissesmac dissesmac Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can make in this way

let i = root.val >= lastVal ? 1 : 0
let left = helper(root.left, max(lastVal, root.val))
let right = helper(root.right, max(lastVal, root.val))
return i + left + right

And using let more profitable for compiler

Copy link
Contributor Author

@nprepaci nprepaci Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestion. Updated in most recent commit.

if root.val >= lastVal {
var left = helper(root.left, max(lastVal, root.val))
var right = helper(root.right, max(lastVal, root.val))
return 1 + left + right
} else {
var left = helper(root.left, max(lastVal, root.val))
var right = helper(root.right, max(lastVal, root.val))
return left + right
}
}
}