Create 0680-valid-palindrome-II.js #1581

aadil42 · 2022-12-23T18:54:14Z

Solution for Valid Palindrome II in JS.

File(s) Added: 0680-Valid-Palindrome-II.js
Language(s) Used: JavaScript
Submission URL: https://leetcode.com/problems/valid-palindrome-ii/submissions/863970166/

Solution for Valid Palindrome II in JS.

aakhtar3 · 2022-12-23T21:26:30Z

javascript/680-Valid-Palindrome-II.js

+var validPalindromeBrute = function(s) {
+
+    for (let i = 0; i < s.length; i++) {
+        if (isPalindrome(s.slice(0, i) + s.slice(i + 1))) return true;


Create a function isValid and invoke it

@aakhtar3, It's done.

renamed isPalindrome to isValid.

aadil42 · 2022-12-24T19:31:42Z

@aakhtar3, I renamed the function. Please check.

aakhtar3 · 2022-12-24T20:10:56Z

javascript/680-Valid-Palindrome-II.js

+var validPalindromeBrute = function(s) {
+
+    for (let i = 0; i < s.length; i++) {
+        if (isValid(s.slice(0, i) + s.slice(i + 1))) return true;


You should invoke the logic in a helper function, not in the if condition
if (isValidPalindrome(...)) return true

aakhtar3 · 2022-12-24T20:11:50Z

javascript/680-Valid-Palindrome-II.js

+        if (s[left] !== s[right]) {
+
+            if (
+                isValid(s.slice(left + 1, right + 1)) ||


aakhtar3 · 2022-12-24T20:12:34Z

javascript/680-Valid-Palindrome-II.js

+ * @return {boolean}
+ */
+//
+var validPalindromeBrute = function(s) {


Since Java script hoist vars, you can have the same name

Added logic inside the helper function. Removed the brute force solution.

aadil42 · 2022-12-24T22:39:52Z

Hey @aakhtar3, I removed the brute force approach and added the logic inside the helper function. Please check.

aakhtar3 · 2022-12-25T02:07:52Z

javascript/680-Valid-Palindrome-II.js

@@ -0,0 +1,35 @@
+/**
+ * Linear Time.
+ * Time O(N) | Space O(1)


Time is N^2

Space is O(N)

aakhtar3 · 2022-12-25T02:08:23Z

javascript/680-Valid-Palindrome-II.js

+
+function isValid(s, left, right) {
+    s = s.slice(left, right);
+    return s.split('').reverse().join('') === s;


You can chain with slice

Ok, But I think that will be too much chaining. People might not understand that. I updated the code.

Updated the Valid-Palindrome-ii.js

aakhtar3 · 2022-12-25T11:32:07Z

javascript/680-Valid-Palindrome-II.js

+ * @param {string} s
+ * @return {boolean}
+ */
+//


aakhtar3 · 2022-12-25T11:36:39Z

javascript/680-Valid-Palindrome-II.js

+    while (left < right) {
+        if (s[left] !== s[right]) {
+
+            if (


This can be cleaned up a bit more

const isValid = isPalindrome(left, right) || isPalindrome(left + 1, right + 1) if (isValid) return true; const isPalindrome = (s, left, right) => { const s = s.slice(left, right) return s === reOrder(s); } const reOrder = (s) => s .split('') .reverse() .join('')

Hey @aakhtar3, We can't reassign s in isPalindrome as this is already coming as a parameter. You forgot to pass the first argument in isPalindrome on the very first line. I did the suggested changes. Please check now.

Oh, sorry I meant you can't re-create the variable by the same name in the isPalindrome.

I update the code with suggested changes. Here's the submission link for the problem -> https://leetcode.com/problems/valid-palindrome-ii/submissions/865395795/

aakhtar3 · 2022-12-25T19:04:49Z

javascript/680-Valid-Palindrome-II.js

+    while (left < right) {
+        if (s[left] !== s[right]) {
+            const isValid = isPalindrome(s, left, right) || isPalindrome(s, left + 1, right + 1);
+            if (isValid) return true;


You can remove if else and just return isValid

That is a great catch!! I'm so stupid. That's great, why didn't I think of that? Thanks, @aakhtar3. I updated the code please check.

Returning isValid instead of checking with the if statement.

Ykhan799 · 2024-10-19T01:14:47Z

@aadil42 rename the file to 0680-valid-palindrome-ii.js to follow Contributing guidelines naming standards.

Additionally, the time complexity is not O(n) since we are performing palindrome inside of a while loop, the time complexity would be O(N^2). Space Complexity would be O(n) since a new string is being constructed with the reOrder function.

aadil42 · 2024-10-23T05:00:23Z

@Ykhan799, yes you're right. Good catch. I have updated the time and space complexity and renamed the file. Please review.

Ykhan799 · 2024-10-24T01:31:53Z

@aadil42 for the file name Valid-Palindrome should all be in lowercase to match the naming standards of all other files. Once you fix this, I'll merge this PR.

aadil42 · 2024-10-24T15:27:44Z

@Ykhan799, someone already contributed the solution for this problem: https://github.com/neetcode-gh/leetcode/blob/main/javascript/0680-valid-palindrome-ii.js

I am closing the PR.

aadil42 · 2024-10-24T15:28:57Z

The solution is added by someone else and this solution is almost identical to it.

Create 680-Valid-Palindrome-II.js

7549e23

Solution for Valid Palindrome II in JS.

aakhtar3 requested changes Dec 23, 2022

View reviewed changes

aadil42 added 3 commits December 25, 2022 00:56

Update 680-Valid-Palindrome-II.js

839bf1d

renamed isPalindrome to isValid.

Update 680-Valid-Palindrome-II.js

d5ffbd5

Update 680-Valid-Palindrome-II.js

6a64091

aakhtar3 reviewed Dec 24, 2022

View reviewed changes

Update 680-Valid-Palindrome-II.js

a8c1ed8

Added logic inside the helper function. Removed the brute force solution.

aakhtar3 requested changes Dec 25, 2022

View reviewed changes

Update 680-Valid-Palindrome-II.js

3c47e94

Updated the Valid-Palindrome-ii.js

aakhtar3 requested changes Dec 25, 2022

View reviewed changes

Update 680-Valid-Palindrome-II.js

eb899e2

I update the code with suggested changes. Here's the submission link for the problem -> https://leetcode.com/problems/valid-palindrome-ii/submissions/865395795/

aakhtar3 requested changes Dec 25, 2022

View reviewed changes

Update 680-Valid-Palindrome-II.js

0fd10df

Returning isValid instead of checking with the if statement.

Rename the file.

e92b425

Correct Time and Space complexity.

279e5bb

aadil42 changed the title ~~Create 680-Valid-Palindrome-II.js~~ Create 0680-Valid-Palindrome-II.js Oct 23, 2024

aadil42 changed the title ~~Create 0680-Valid-Palindrome-II.js~~ Create 0680-valid-palindrome-II.js Oct 24, 2024

aadil42 closed this Oct 24, 2024

Create 0680-valid-palindrome-II.js #1581

Create 0680-valid-palindrome-II.js #1581

Uh oh!

Conversation

aadil42 commented Dec 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aadil42 Dec 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aadil42 commented Dec 24, 2022

Uh oh!

aakhtar3 Dec 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aadil42 commented Dec 24, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ykhan799 commented Oct 19, 2024

Uh oh!

aadil42 commented Oct 23, 2024

Uh oh!

Ykhan799 commented Oct 24, 2024

Uh oh!

aadil42 commented Oct 24, 2024

Uh oh!

aadil42 commented Oct 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aadil42 commented Dec 23, 2022 •

edited

Loading

aadil42 Dec 24, 2022 •

edited

Loading

aakhtar3 Dec 24, 2022 •

edited

Loading