Skip to content

Conversation

FilipeLipan
Copy link
Contributor

@FilipeLipan FilipeLipan commented May 1, 2023

Made a solution closer to the python solution, the previous kotlin solution it's faster, but very different from the video explanation https://www.youtube.com/watch?v=s7AvT7cGdSo

@a93a
Copy link
Collaborator

a93a commented May 5, 2023

Hi! Your submission link seems to be incorrect. Could you provide the correct one, please ?

@FilipeLipan
Copy link
Contributor Author

FilipeLipan commented May 5, 2023

@a93a
I change to https://leetcode.com/problems/permutations/submissions/942342203/
sorry for the trouble

@a93a
Copy link
Collaborator

a93a commented May 6, 2023

@FilipeLipan Thanks! I don't see a reason to completly overrid the old solution, but we can add yours too (several different solutions in the same file are OK, as long as they differ but still manage to solve the problem).

Could you do some changes to your file and add some separation between the solutions, and I could merge.

for example:

// solution one
class Solution {
    fun permute(nums: IntArray): List<List<Int>> {
        //....
    }
}

// solution two 
class Solution {
    fun permute(nums: IntArray): List<List<Int>> {
        //....
    }
}

@FilipeLipan
Copy link
Contributor Author

@a93a, I've done it! I'm submitting this solution because I found it annoying to study with the other solution that had a different strategy from the one in the video (https://www.youtube.com/watch?v=s7AvT7cGdSo). Please let me know if you have any questions or change requests.

@a93a
Copy link
Collaborator

a93a commented May 14, 2023

Yes I understand, thanks for the help. You can put the video solution at top instead if you would like, I think it's better? So it's the first you see when you check the file.

@FilipeLipan
Copy link
Contributor Author

@a93a done!!

@a93a
Copy link
Collaborator

a93a commented May 17, 2023

Thanks a lot @FilipeLipan and thanks for your contribution!

@a93a a93a merged commit 8f7e02c into neetcode-gh:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants