Skip to content

Create 0187-repeated-dna-sequences.js #2557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 20, 2023
Merged

Create 0187-repeated-dna-sequences.js #2557

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
97d9ab2
Create 0187-repeated-dna-sequences.js
aadil42 Jun 9, 2023
18467a0
Update 0187-repeated-dna-sequences.js
aadil42 Jul 1, 2023
047feab
Update 0187-repeated-dna-sequences.js
aadil42 Jul 2, 2023
3c1231a
Update 0187-repeated-dna-sequences.js
aadil42 Jul 20, 2023
81ba7c5
Merge branch 'main' into patch-49
aadil42 Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions javascript/0187-repeated-dna-sequences.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
/**
* https://leetcode.com/problems/repeated-dna-sequences/
* Hashing
* s = the number of letters in the sequance. In our case it's 10. so the time complexity would be 10*n which boils down to n.
* Time O(s*n) | Space O(n)
* @param {string} s
* @return {string[]}
*/

var findRepeatedDnaSequences = function(s) {

const sequanceStack = new Set();
Copy link
Collaborator

@aakhtar3 aakhtar3 Jul 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable names are misleading

const sequenceSet = new Set();
const resultSet = new Set();

return [ ...resultSet ];

Copy link
Contributor Author

@aadil42 aadil42 Jul 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, my bad. Sorry. I updated the variables.

let resultStack = new Set();

for(let i = 0; i < s.length; i++) {
const subSequance = getSubSequance(s,i,10);
if(sequanceStack.has(subSequance)) {
resultStack.add(subSequance);
} else {
sequanceStack.add(subSequance);
}
}

resultStack = [...resultStack];
return resultStack;
};

function getSubSequance(s,i,len) {
return s.slice(i, i + len);
Copy link
Collaborator

@aakhtar3 aakhtar3 Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: This will change your time complexity. Refactor or review your Time O()

Copy link
Contributor Author

@aadil42 aadil42 Jul 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, the len parameter is a constent(10 in this case). so the the time complexity would be 10*n which is still n right? Aren't we suppose to ignore the coefficient? But I have changed the time coplexity in the comment nonetheless.

Copy link
Collaborator

@aakhtar3 aakhtar3 Jul 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right! Since it is a constant, we can ignore the auxiliary space.

}