Skip to content

Conversation

faithandlogic
Copy link
Contributor

=]

@mitchellirvin
Copy link
Collaborator

Hi @blurout ! Sorry it's taken so long to review this. Do you mind updating to handle the merge conflcits?

@faithandlogic
Copy link
Contributor Author

No problem @mitchellirvin , I'll add a couple more solutions as well before I do so.

@faithandlogic
Copy link
Contributor Author

@mitchellirvin Done. Should be good to go.

Copy link
Collaborator

@mitchellirvin mitchellirvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more small things, thanks @blurout !

@@ -0,0 +1,39 @@
func threeSum(nums []int) [][]int {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we de-dupe the arrayAndHashing and Arrays & Hashing dirs?

@@ -0,0 +1,13 @@
package arrayAndHashing
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: do you mind matching the naming convention for all these files & folders to be the same as the cpp dir? https://github.com/neetcode-gh/leetcode/tree/main/cpp/neetcode_150

the dir and file names should all be snake_case

@Ahmad-A0
Copy link
Collaborator

Thanks, @blurout! Sorry for taking so long to merge this PR, unfortunately this means I had to delete some files as duplicates.

@Ahmad-A0 Ahmad-A0 merged commit d92cbba into neetcode-gh:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants