Added a more readable decode logic #296
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing decode logic looked confusing. So I have added a more readable one along with inline comments so that anyone can understand it better.
mitchellirvin
requested changes
Jul 12, 2022
There was a problem hiding this comment.
hi @anushibin007 ! thanks for contributing!
do you mind resolving the merge conflicts? it seems like the solution was updated and some of the code changed
|
closing as stale! please feel free to reopen once the changes have been made, provided there are no existing solutions for the problems given |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing decode logic looked confusing. So I have added a more readable one along with inline comments so that anyone can understand it better.