Skip to content

Conversation

GokhanCagritekin
Copy link
Contributor

No description provided.

Copy link
Collaborator

@mitchellirvin mitchellirvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @GokhanCagritekin ! thank you for contributing!

a couple small things:

  1. this is currently admittedly inconsistent, and we do need to figure out a better long term approach, but do you mind moving all of your solutions to the go/ directory (instead of inside backtracking/)? in the future we'll get a neetcode_150 directory set up with all of the categories, but until then let's keep this at the top level
  2. do you mind updating your file names to match the convention that exists elsewhere in the repo? currently it's <problem-number>-Name-of-Problem.<language-extension> see the contributing guidelines for details

@GokhanCagritekin
Copy link
Contributor Author

Hi @mitchellirvin . Thank you for your feedback. I just updated my pull request.

@Ahmad-A0
Copy link
Collaborator

Thanks, @GokhanCagritekin!

@Ahmad-A0 Ahmad-A0 merged commit ffaa2d4 into neetcode-gh:main Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants