-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Adding solutions in go #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Did some modularization for better representation. Instead of having main packages made the packages with the method name
...65_Non_decreasing_Array/238_Product_of_Array_Except_Self/238_Product_of_Array_Except_Self.go
Show resolved
Hide resolved
Hi @Maximilian5189 Could you review this and if you have write access request you to merge the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @khvr1993 ! thanks so much for working on all of these problems.
a couple things:
- do you mind removing the test files (we currently don't track test files in any other language/area, and it's highly likely they would diverge from the source code over time, though I love your enthusiasm for tests!)
- do you mind moving all of the solutions to the top level
go/
directory? admittedly this guidance isn't clear, but I think we're going to move to keeping all solutions in the top level dir of each language to make searchability easier - do you mind updating the file names to match the existing conventions? details can be found here: https://github.com/neetcode-gh/leetcode#guidelines
- do you mind breaking this PR up into a few smaller PRs for review? I usually wouldn't recommend doing more than a handful of solutions per-PR, as it increases the time it takes for review and merging, and it decreases the confidence we have that everything we're merging is correct
Once these things are done, I'll go through and review each solution and verify it passes submission on leetcode.com (and that there isn't already an existing solution in the repo for go). we're super grateful for the contributions, but in the future if you keep your PRs smaller, it'll take less time to get it reviewed and merged!
@mitchellirvin Thanks for the suggestions.
|
@khvr1993 thanks so much! Please link the PRs when they're open and I'll review them as soon as I can. I trust that you've submitted them on leetcode and they pass, I just always have to go run them myself just in case! |
I'll close this as stale since the directory structure for go solutions has changed, feel free to update the structure in which case I'll reopen and merge this. |
I will be adding solutions one by one as I go through the questions. This is a work in progress PR