Create/Read working in quick and dirty PoC #6
Conversation
| if (serverCertVerificationDisabled) { | ||
| sslContextBuilder.trustManager(InsecureTrustManagerFactory.INSTANCE); // disable cert verification | ||
| } | ||
| sslContextBuilder.trustManager(InsecureTrustManagerFactory.INSTANCE); // disable cert verification |
There was a problem hiding this comment.
Assuming this would be removed after we do another round of cleanup, correct?
There was a problem hiding this comment.
Maybe we should remove it now honestly - I think it's risky to leave this as a TODO
| OperationType.Read, ResourceType.Document, path, requestHeaders, options); | ||
|
|
||
| request.useThinProxy = Configs.isThinClientEnabled() && request.useGatewayMode ? true : false; | ||
| request.useThinProxy = true; |
There was a problem hiding this comment.
NIT: Remove this I think right? Leaving comment here for future tracking, non-blocking
| public void encode(final ByteBuf out, boolean forThinClient) { | ||
|
|
||
| final int expectedLength = RntbdRequestFrame.LENGTH + this.headers.computeLength(); | ||
| final int effectivePayloadSize = this.payload != null && this.payload.length > 0 ? this.payload.length + 4 : 0; |
There was a problem hiding this comment.
Non-blocking: why +4? I see it's only being used for logging but just wondering where this number came from
nehrao1
left a comment
nehrao1
left a comment
There was a problem hiding this comment.
Thank you very much Fabian - not sure if always disabling cert verification would be a good idea and I am scared we would forget to fix this later, could you please comment on this? Otherwise LGTM.
2 participants
No description provided.