Skip to content

proposal: NeoFS block storage format #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

proposal: NeoFS block storage format #194

wants to merge 2 commits into from

Conversation

AliceInHunterland
Copy link
Contributor

No description provided.

shargon
shargon reviewed Apr 8, 2025
View reviewed changes
roman-khimov
roman-khimov requested changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Index files? Synchronization algorithm?

@Jim8y
Copy link
Contributor

Jim8y commented Apr 11, 2025

@AliceInHunterland please update accordingly, this is not likely can be reviewed with any useful suggestions from other coredevs since we know little about neofs, please just follow roman's suggestion

@AliceInHunterland AliceInHunterland force-pushed the neofs-blocks branch 2 times, most recently from 1231891 to 6c12fbe Compare April 18, 2025 05:11
AnnaShaleva
AnnaShaleva reviewed Jun 24, 2025
View reviewed changes
neofs-blocks.mediawiki Outdated
Comment on lines 38 to 82
An [https://rest.fs.neo.org/v1/objects/3RCdP3ZubyKyo8qFeo7EJPryidTZaGCMdUjqFJaaEKBV/by_id/Fu7yQzspvLJwSGJNK64xeeyMdWXtU5B5b1es6KSxUag1 example]
of a block object is as follows:
<pre>
ID: Fu7yQzspvLJwSGJNK64xeeyMdWXtU5B5b1es6KSxUag1
CID: 3RCdP3ZubyKyo8qFeo7EJPryidTZaGCMdUjqFJaaEKBV
Owner: NVvY1FF67XJ2GTVhy9FqiZGC4jEQtvjmHt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it correct to attach object link as an example? This object/container may be removed in future whereas we expect NEP to be consistent. @roman-khimov?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example can be a proper example with this data if needed. It doesn't imply any of the IDs are relevant for mainnet or whatever else.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted.

@Jim8y Jim8y mentioned this pull request Jun 26, 2025
Closed
@AnnaShaleva AnnaShaleva force-pushed the neofs-blocks branch 3 times, most recently from b02aabe to b795db3 Compare July 7, 2025 09:08
@AnnaShaleva
Copy link
Member

@roman-khimov, let's review one more time.

roman-khimov
roman-khimov reviewed Jul 10, 2025
View reviewed changes
@AnnaShaleva AnnaShaleva requested a review from roman-khimov July 10, 2025 14:20
Jim8y
Jim8y previously approved these changes Jul 11, 2025
View reviewed changes
@Jim8y
Copy link
Contributor

Jim8y commented Jul 11, 2025

LGTM. I prefer to approve the general logic as long as its correct and complete, then polish the format later.

Wi1l-B0t
Wi1l-B0t reviewed Jul 11, 2025
View reviewed changes
Wi1l-B0t
Wi1l-B0t reviewed Jul 11, 2025
View reviewed changes
@AnnaShaleva AnnaShaleva requested review from Wi1l-B0t and Jim8y July 18, 2025 08:19
@AnnaShaleva AnnaShaleva mentioned this pull request Aug 27, 2025
Closed
@AnnaShaleva
Copy link
Member

@neo-project/core let's review this proposal one more time.

shargon
shargon reviewed Oct 2, 2025
View reviewed changes
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • TimeStamp for upload time seems very similar to BlockTime, maybe use UploadedTime or StoredAt instead could be more clear
  • It's possible to recover a block range 1-1000 ? without 1000 requests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon left review comments

@Wi1l-B0t Wi1l-B0t Wi1l-B0t approved these changes

@AnnaShaleva AnnaShaleva Awaiting requested review from AnnaShaleva

@cschuchardt88 cschuchardt88 Awaiting requested review from cschuchardt88

@vncoelho vncoelho Awaiting requested review from vncoelho

@roman-khimov roman-khimov Awaiting requested review from roman-khimov

@Jim8y Jim8y Awaiting requested review from Jim8y

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AliceInHunterland @Jim8y @AnnaShaleva @shargon @roman-khimov @Wi1l-B0t