Skip to content

Update en_us.json#282

Closed
Thunderrock424242 wants to merge 2 commits intoneoforged:mainfrom
Thunderrock424242:patch-1
Closed

Update en_us.json#282
Thunderrock424242 wants to merge 2 commits intoneoforged:mainfrom
Thunderrock424242:patch-1

Conversation

@Thunderrock424242
Copy link
Copy Markdown

fixing some things with the missing classes instead of has mods that are missing it should be missing classes that are not found

checking for other grammer mistakes

fixing some things with the missing classes instead of has mods that are missing it should be missing classes that are not found
@neoforged-pr-publishing
Copy link
Copy Markdown

  • Publish PR to GitHub Packages

@Thunderrock424242 Thunderrock424242 marked this pull request as ready for review May 10, 2025 03:35
@sciwhiz12
Copy link
Copy Markdown
Member

Hello! I don't think we use that translation key anymore, particularly because FML is hardcoded to reject any ModLoadingIssue that uses any translation key that starts with fml. but doesn't start with fml.modloadingissue. (See

// Make sure it's easy for us to know which translation keys get access to the implicit args at indices 100 and above
if (translationKey.startsWith("fml.") && !translationKey.startsWith("fml.modloadingissue.")) {
throw new IllegalArgumentException("When using FML translation keys, only use fml.modloadingissue. keys for mod loading issues: " + translationKey);
}
)

We should look through all the translation keys and clean up those that are unused.

Thanks for your contribution anyway!

@sciwhiz12 sciwhiz12 closed this Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants