impl burning of gas, add caller_token to AccountMeta of Cancel operation #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinev-valentine
changed the title
sinev-valentine
changed the title
otselnik
reviewed
Sep 10, 2021
otselnik
reviewed
Sep 10, 2021
evm_loader/program/src/entrypoint.rs
Outdated
| let fee = U256::from(used_gas) | ||
| .checked_mul(gas_price_wei).ok_or_else(||E!(ProgramError::InvalidArgument))?; | ||
|
|
||
| let (caller_info, caller_token_info) = account_storage.get_caller_account_info().ok_or_else(||E!(ProgramError::InvalidArgument))?; |
Contributor
There was a problem hiding this comment.
Why user token is being getting here, but not mentioned in accounts like in Continue or CallFromRawEthereumTX
otselnik
reviewed
Sep 10, 2021
| let AccountMeta{ account, token: _, code: _ } = &self.account_metas[account_index]; | ||
| return Some(account); | ||
| let AccountMeta{ account, token, code: _ } = &self.account_metas[account_index]; | ||
| return Some((account, token)); |
Contributor
There was a problem hiding this comment.
Do we really need token account to be returned?
Contributor
Author
There was a problem hiding this comment.
token was removed
Contributor
|
Caller token for payment for transaction should be passed in first part of accounts list, and there is no need for returning token account in |
s-medvedev
previously approved these changes
Sep 20, 2021
s-medvedev
approved these changes
Sep 24, 2021
arkadyone
pushed a commit
to arkadyone/neon-evm
that referenced
this pull request
Nov 25, 2022
Dev docs restructure
afalaleev
pushed a commit
that referenced
this pull request
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cancel operation is processed it is need to transfer all used gas to operator
Dependency: neonlabsorg/proxy-model.py#178