Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
90a4e56
#291 extract transaction sender class
otselnik Nov 14, 2021
143913b
#291 move perm accs to transaction sender
otselnik Nov 16, 2021
16c9bff
#291 fix state
otselnik Nov 22, 2021
f2c0303
#291 fix errors
otselnik Nov 23, 2021
57f3b53
Merge remote-tracking branch 'origin/develop' into 291_proxy_refactoring
otselnik Nov 23, 2021
3369f67
#291 merge fixes
otselnik Nov 23, 2021
af721bb
#291 refactoring
otselnik Nov 23, 2021
e512bb8
#291 move EXTRA_GAS to environment
otselnik Nov 23, 2021
8dc5e29
#291 capitalize CONFIRMATION_CHECK_DELAY
otselnik Nov 23, 2021
8dce2a5
#291 sort imports
otselnik Nov 23, 2021
cef8f21
#291 relative paths
otselnik Nov 24, 2021
1bf8383
#291 Should be fixed in #326
otselnik Nov 24, 2021
9672438
#291 testing chnages
otselnik Nov 24, 2021
2d42b73
fix storage account check
sinev-valentine Nov 24, 2021
ac2755c
Merge remote-tracking branch 'origin/develop' into 291_proxy_refactoring
otselnik Nov 24, 2021
3519c61
Merge branch '371_add_FinalizedStorage_to_check' into 291_proxy_refac…
otselnik Nov 24, 2021
bf313a2
#291 rename `trx_with_create_and_airdrop` -> `make_trx_with_create_an…
otselnik Nov 24, 2021
3093fcc
Merge remote-tracking branch 'origin/develop' into 291_proxy_refactoring
otselnik Nov 24, 2021
e3c4e33
#295 fix state
otselnik Nov 24, 2021
9b57e53
#291 iterative combined
otselnik Nov 25, 2021
ccffcf4
#295 do not get measurments
otselnik Nov 25, 2021
4d685db
#291 pull request fixes
otselnik Nov 25, 2021
6f63338
Merge remote-tracking branch 'origin/develop' into 291_proxy_refactoring
otselnik Nov 25, 2021
4546926
Merge branch '291_proxy_refactoring' into 295_iterative_execution
otselnik Nov 25, 2021
7befc6b
#295 turn combined instructions ON
otselnik Nov 29, 2021
b5010f8
#295 make neon_instructions return transasactions
otselnik Nov 29, 2021
5ebf76a
Merge remote-tracking branch 'origin/develop' into 291_proxy_refactoring
otselnik Dec 2, 2021
b464b1e
#291 merge fix
otselnik Dec 2, 2021
79088c6
#295 get rid of `USE_COMBINED_START_CONTINUE`
otselnik Dec 2, 2021
52173a0
Merge branch '291_proxy_refactoring' into 295_iterative_execution
otselnik Dec 2, 2021
4fe15e9
#295 requested fixes
otselnik Dec 2, 2021
607e74e
Merge remote-tracking branch 'origin/develop' into 295_iterative_exec…
otselnik Dec 2, 2021
d9f762a
#295 call_continue_bucked refactoring
otselnik Dec 2, 2021
842ec7d
#295 fix
otselnik Dec 3, 2021
78de121
#295 leave only combined iterative transactions
otselnik Dec 3, 2021
47cf219
#295 move constants into class
otselnik Dec 3, 2021
0eebc1f
#295 refactoring
otselnik Dec 3, 2021
cec7a38
Merge remote-tracking branch 'origin/develop' into 295_iterative_exec…
otselnik Dec 6, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
#291 iterative combined
  • Loading branch information
otselnik committed Nov 25, 2021
commit 9b57e5351adb3462566bd5f0e614a37bf490fe0c
53 changes: 53 additions & 0 deletions proxy/common_neon/neon_instruction.py
Original file line number Diff line number Diff line change
Expand Up @@ -373,3 +373,56 @@ def make_cancel_instruction(self) -> Transaction:
AccountMeta(pubkey=SYSVAR_INSTRUCTION_PUBKEY, is_signer=False, is_writable=False),
] + obligatory_accounts
))


def make_partial_call_or_continue_instruction(self, steps: int = 0) -> TransactionInstruction:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annotations

data = bytearray.fromhex("0D") + self.collateral_pool_index_buf + steps.to_bytes(8, byteorder="little") + self.msg
return TransactionInstruction(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it better if it would be separated on two parts. The part that is passed in - is too long

instraction = 
...
return instruction

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This remark could be connected to the previous definition as well

program_id = EVM_LOADER_ID,
data = data,
keys = [
AccountMeta(pubkey=self.storage, is_signer=False, is_writable=True),

AccountMeta(pubkey=SYSVAR_INSTRUCTION_PUBKEY, is_signer=False, is_writable=False),
AccountMeta(pubkey=self.operator, is_signer=True, is_writable=True),
AccountMeta(pubkey=self.collateral_pool_address, is_signer=False, is_writable=True),
AccountMeta(pubkey=self.operator_token, is_signer=False, is_writable=True),
AccountMeta(pubkey=self.caller_token, is_signer=False, is_writable=True),
AccountMeta(pubkey=SYS_PROGRAM_ID, is_signer=False, is_writable=False),

] + self.eth_accounts + [

AccountMeta(pubkey=SYSVAR_INSTRUCTION_PUBKEY, is_signer=False, is_writable=False),
] + obligatory_accounts
)


def make_partial_call_or_continue_transaction(self, steps: int = 0, length_before: int = 0) -> Transaction:
trx = Transaction()
trx.add(self.make_keccak_instruction(length_before + 1, len(self.eth_trx.unsigned_msg()), 13))
trx.add(self.make_partial_call_or_continue_instruction(steps))
return trx


def make_partial_call_or_continue_from_account_data(self, steps, index=None) -> Transaction:
data = bytearray.fromhex("0E") + self.collateral_pool_index_buf + steps.to_bytes(8, byteorder='little')
if index:
data = data + index.to_bytes(8, byteorder="little")
return TransactionInstruction(
program_id = EVM_LOADER_ID,
data = data,
keys = [
AccountMeta(pubkey=self.holder, is_signer=False, is_writable=True),
AccountMeta(pubkey=self.storage, is_signer=False, is_writable=True),

AccountMeta(pubkey=self.operator, is_signer=True, is_writable=True),
AccountMeta(pubkey=self.collateral_pool_address, is_signer=False, is_writable=True),
AccountMeta(pubkey=self.operator_token, is_signer=False, is_writable=True),
AccountMeta(pubkey=self.caller_token, is_signer=False, is_writable=True),
AccountMeta(pubkey=SYS_PROGRAM_ID, is_signer=False, is_writable=False),

] + self.eth_accounts + [

AccountMeta(pubkey=SYSVAR_INSTRUCTION_PUBKEY, is_signer=False, is_writable=False),
] + obligatory_accounts
)
3 changes: 2 additions & 1 deletion proxy/common_neon/solana_interactor.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import re
import time

from solana.rpc.api import Client as SolanaClient
from solana.rpc.commitment import Confirmed
from solana.rpc.types import TxOpts

Expand All @@ -17,7 +18,7 @@


class SolanaInteractor:
def __init__(self, signer, client) -> None:
def __init__(self, signer, client: SolanaClient) -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

signer needs its own annotation as well

self.signer = signer
self.client = client

Expand Down
81 changes: 75 additions & 6 deletions proxy/common_neon/transaction_sender.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,19 @@
from .layouts import ACCOUNT_INFO_LAYOUT
from .neon_instruction import NeonInstruction
from .solana_interactor import SolanaInteractor, check_if_continue_returned, check_if_program_exceeded_instructions
from ..environment import EVM_LOADER_ID
from ..environment import EVM_LOADER_ID, USE_COMBINED_START_CONTINUE
from ..plugin.eth_proto import Trx as EthTrx


logger = logging.getLogger(__name__)
logger.setLevel(logging.DEBUG)


CONTINUE_REGULAR = 'ContinueV02'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class A:
    CONSTANT1 = "Hi Dmitrii!!!"
    
    def foo(self):
        print(f"{self.CONSTANT1}")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need explanation

CONTINUE_COMBINED = 'PartialCallOrContinueFromRawEthereumTX'
CONTINUE_HOLDER_COMB = 'ExecuteTrxFromAccountDataIterativeOrContinue'


class TransactionSender:
def __init__(self, solana_interactor: SolanaInteractor, eth_trx: EthTrx, steps: int) -> None:
self.sender = solana_interactor
Expand Down Expand Up @@ -348,13 +353,13 @@ def call_signed_iterative(self):
call_txs = self.instruction.make_iterative_call_transaction()
self.sender.send_measured_transaction(call_txs, self.eth_trx, 'PartialCallFromRawEthereumTXv02')

return self.call_continue()
return self.call_continue(CONTINUE_REGULAR)


def call_signed_iterative_combined(self):
self.create_accounts_for_trx_if_needed()

return self.call_continue_combined()
return self.call_continue(CONTINUE_COMBINED)


def call_signed_with_holder_acc(self):
Expand All @@ -365,13 +370,13 @@ def call_signed_with_holder_acc(self):
call_txs = self.instruction.make_call_from_account_instruction()
self.sender.send_measured_transaction(call_txs, self.eth_trx, 'ExecuteTrxFromAccountDataIterativeV02')

return self.call_continue()
return self.call_continue(CONTINUE_REGULAR)

def call_signed_with_holder_combined(self):
self.write_trx_to_holder_account()
self.create_accounts_for_trx_if_needed()

return self.call_continue_with_holder_combined()
return self.call_continue(CONTINUE_HOLDER_COMB)


def create_accounts_for_trx_if_needed(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just create_accounts_for_trx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Expand Down Expand Up @@ -399,7 +404,21 @@ def write_trx_to_holder_account(self):
self.sender.collect_results(receipts, eth_trx=self.eth_trx, reason='WriteHolder')


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single blank line in python classes separates methods

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need just some issue for styling. Not here

def call_continue(self):
def call_continue(self, instruction_type):
return_result = None
try:
return_result = self.call_continue_bucked(instruction_type)
except Exception as err:
logger.debug("call_continue_bucked_combined exception:")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logger.debug(f"Calling continue bucked combined failed, error: {err}")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

logger.debug(str(err))

if return_result is not None:
return return_result

return self.call_continue_iterative()


def call_continue_iterative(self):
try:
return self.call_continue_step_by_step()
except Exception as err:
Expand Down Expand Up @@ -441,3 +460,53 @@ def call_cancel(self):
logger.debug("Cancel")
result = self.sender.send_measured_transaction(trx, self.eth_trx, 'CancelWithNonce')
return result['result']['transaction']['signatures'][0]


def call_continue_bucked(self, instruction_type):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annotations?

logger.debug("Send bucked combined:")
steps = self.steps

addition_count = 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block looks suspiciously, to tell you the truth

if instruction_type == CONTINUE_COMBINED:
addition_count = 2
elif instruction_type == CONTINUE_HOLDER_COMB:
addition_count = 1

receipts = []
for index in range(math.ceil(self.steps_emulated/steps) + addition_count):
try:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method is too heave, you can isolate some logically independent parts


if instruction_type == CONTINUE_REGULAR:
trx = self.instruction.make_continue_instruction(steps, index)
elif instruction_type == CONTINUE_COMBINED:
trx = self.instruction.make_partial_call_or_continue_transaction(steps - index)
elif instruction_type == CONTINUE_HOLDER_COMB:
trx = self.instruction.make_partial_call_or_continue_from_account_data(steps, index)
else:
raise Exception("Unknown contionue type: {}".format(instruction_type))

result = self.sender.send_transaction_unconfirmed(trx)
receipts.append(result)
except Exception as err:
logger.debug(str(err))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logger.error(f"Failed to call continue bucked, error: {err}")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

if str(err).startswith("Transaction simulation failed: Error processing Instruction 0: custom program error: 0x1"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should extend SolanaErrors enum with it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need explanaition

pass
elif str(err).startswith("Transaction simulation failed: Error processing Instruction 0: custom program error: 0x4"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should extend SolanaErrors enum with it

On the top of that there in errors.py you left:

  1. Single line separator before SolanaErrors
  2. CamelCase named method getError

pass
elif check_if_program_exceeded_instructions(err.result):
steps = int(steps * 90 / 100)
else:
raise

return self.collect_bucked_results(receipts, instruction_type)


def collect_bucked_results(self, receipts, reason):
logger.debug("Collect bucked results:")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to move logging up to one level because you're already logging the logic there.

logger.debug(f"Collected bucked results: {receipts}")

This method resembles just a getter with no interaction

logger.debug("receipts %s", receipts)
result_list = self.sender.collect_results(receipts, eth_trx=self.eth_trx, reason=reason)
for result in result_list:
self.sender.get_measurements(result)
signature = check_if_continue_returned(result)
if signature:
return signature