Skip to content

338 create sol price provider #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
s-medvedev merged 31 commits into from
Dec 16, 2021
Merged

338 create sol price provider #346

s-medvedev merged 31 commits into from
Dec 16, 2021

Conversation

@ivandzen
Copy link
Contributor

@ivandzen ivandzen commented Dec 3, 2021

No description provided.

ivanl added 25 commits December 1, 2021 13:36
cherrypick part of changes
5984c19
create indexer.py
613a469
remove solana_receipts_update.py
c0d0e6c
Cherry pick files from old branch
3f6b5c4
add requirement
0790298
fix refactoring issues
340c854
Fix inspection issues
7449b38
fix last issue
b3dacfa
Merge branch '336_indexer_refactoring' into 337_сreate_base_airdroppe…
a50cd47 
…r_service
Merge remote-tracking branch 'origin/develop' into 337_сreate_base_ai…
2b8f879 
…rdropper_service
simplify tests
f51f2ed
add test
6678924
Merge remote-tracking branch 'origin/develop' into 337_сreate_base_ai…
5d454b7 
…rdropper_service
add price provider
add136a
fix PriceProvider, add test
9a4be44
Add tests. Check worn on all nets
07aaca8
refactoring
7a46c12
integrate price_provider into airdropper
2fc1424
integrate price provider
d157d67
use new faucet method
8a6abfd
add new parameter to airdropper main
3d4dec9
Test discriptions for airdropper
5c29832
Comments for price provider tests
6a4efdc
remove unnecessary comment
14aeeed
Merge remote-tracking branch 'origin/develop' into 338_create_sol_pri…
bd35791 
…ce_provider
s-medvedev
s-medvedev reviewed Dec 14, 2021
View reviewed changes
proxy/indexer/airdropper.py
Comment on lines 98 to 99
self.airdrop_ready[eth_address] = create_acc

Copy link
Contributor

@s-medvedev s-medvedev Dec 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like a duplicate.

Copy link
Contributor Author

@ivandzen ivandzen Dec 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@s-medvedev
Copy link
Contributor

s-medvedev commented Dec 15, 2021

In general, we have two issues with this PR:

  1. using floating-point arithmetic for the price can lead to inaccuracies in the calculations. In this case, this may be acceptable, since the SOL/USDT price is determined with some margin of error. We should decide whether this is a problem, but this does not interfere with the injection of this PR.
  2. in case we cannot get the price, we continue to use the old value. There are several questions here:
    • how often can situations arise when the price is not available? how long do they last? I mean, are there systematic periods of time when the price is not available?
    • what should be done in this case when starting or restarting the service? Now the service is starting, but the funds are not credited to users.
    • how do we need to track the impossibility of obtaining the current price? I'm talking about the infrastructure level now.

@s-medvedev s-medvedev merged commit 25734a3 into develop Dec 16, 2021
@s-medvedev s-medvedev deleted the 338_create_sol_price_provider branch December 16, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@otselnik otselnik Awaiting requested review from otselnik

1 more reviewer

@s-medvedev s-medvedev s-medvedev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ivandzen @s-medvedev