421 optimise indexer transaction receipt storage #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otselnik
reviewed
Dec 29, 2021
| return b58encode(signature).decode("utf-8") | ||
|
|
||
| def create_slot_sig(self, max_slot): | ||
| slot = randint(0, max_slot) |
Contributor
There was a problem hiding this comment.
random slot makes test fail "randomly"
Contributor
There was a problem hiding this comment.
======================================================================
FAIL: test_query (proxy.testing.test_trx_receipts_storage.TestTrxReceiptsStorage)
Test get_trxs method workds as expected
----------------------------------------------------------------------
Traceback (most recent call last):
File "/opt/proxy/testing/test_trx_receipts_storage.py", line 63, in test_query
self.assertEqual(retrieved_trxs[0][0], start_slot)
AssertionError: 35 != 34
----------------------------------------------------------------------
Contributor
Author
There was a problem hiding this comment.
Thank you! This is due to probabilistic reasons: sometimes generated data not contains any transaction for given slot. In average, it will exist only two transaction for every given slot with current generation parameters (100 trxs in 50 slots randomly), but in reality there a cases when there are no transactions for given slot at all. Actually, testing expression must cover such cases, so I changed it.
otselnik
approved these changes
Dec 29, 2021
| max_slot = max(max_slot, slot) | ||
| if slot < self.latest_processed_slot: | ||
| break | ||
| if trx['transaction']['message']['instructions'] is not None: |
Contributor
There was a problem hiding this comment.
from ..common_neon.utils import get_from_dict
...
get_from_dict(trx, 'transaction', 'message', 'instructions')| cur.execute(f'SELECT 1 FROM {self.table_name} WHERE slot = %s AND signature = %s', (slot, signature,)) | ||
| return cur.fetchone() is not None | ||
|
|
||
| def get_trxs(self, start_slot = 0, reverse = False): |
Contributor
There was a problem hiding this comment.
You don't need extra spaces around = according to PEP8
def get_trxs(self, start_slot=0, reverse=False):
otselnik
deleted the
421_optimise_indexer_transaction_receipt_storage
branch
otselnik
added a commit
that referenced
this pull request
Dec 30, 2021
* #409 indexer optomizations * #409 catch exceptiopns * #409 add airdropper and faucet artifacts * #409 remove unused variables * #409 return`self.last_slot` to `IndexerBase` class * #409 merge SQLDict and SQLDictBinKey classes to one * #409 remove debug log * #409 add metrics * 421 optimise indexer transaction receipt storage (#423) * Create TrxReceiptsStorage * Use new container in indexer and airdropper * Fix bug * Fix assertions in tests, use random start_slot Co-authored-by: Ivan Loboda <[email protected]> Co-authored-by: ivandzen <[email protected]> Co-authored-by: Ivan Loboda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.