Fix eth_estimateGas for Metamask transfer #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-lisanin
changed the title
afalaleev
approved these changes
Mar 14, 2022
| self.data = request.get('data', '0x')[2:] | ||
| self.sender = request.get('from') or '0x0000000000000000000000000000000000000000' | ||
| if self.sender: | ||
| self.sender = self.sender[2:] |
Contributor
There was a problem hiding this comment.
IMHO, the previous realization is the same, but shorter
Contributor
Author
There was a problem hiding this comment.
I thought the same, but it is not.
request.get('data', '0x') can return valid hex string, empty string, '0x', or None
And if it is empty string or None it will cause exception
valiksinev
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this Metamask will correctly display gas limit for Neon transfer to non existing account