Skip to content

NDEV-2438: Simplify Rpc trait usage #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andreisilviudragnea merged 1 commit into from
Dec 12, 2023
Merged

NDEV-2438: Simplify Rpc trait usage #245

andreisilviudragnea merged 1 commit into from
Dec 12, 2023

Conversation

@andreisilviudragnea
Copy link

@andreisilviudragnea andreisilviudragnea commented Dec 11, 2023 •
edited
Loading

Addendum to #233.

  • Simplified Rpc trait usage (removed the need to wrap Solana RpcClient in RpcEnum using rpc_client.clone().into(), since both RpcClient and RpcEnum implement Rpc, so impl Rpc parameters accept both)
  • Extracted BuildConfigSimulator trait
  • Converted ConfigSimulator functions to methods
  • Renamed some local variables

@andreisilviudragnea andreisilviudragnea changed the title NDEV-2438: Clean up Rpc trait usage NDEV-2438: Simplify Rpc trait usage Dec 11, 2023
@andreisilviudragnea andreisilviudragnea force-pushed the NDEV-2438 branch 2 times, most recently from 20a9711 to a1bc32b Compare December 11, 2023 20:23
@andreisilviudragnea
NDEV-2438: Simplify Rpc trait usage
2eac715 
- Extracted BuildConfigSimulator trait
- Converted ConfigSimulator functions to methods
Deniskore
Deniskore approved these changes Dec 12, 2023
View reviewed changes
Copy link

@Deniskore Deniskore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andreisilviudragnea andreisilviudragnea merged commit acf2ef1 into develop Dec 12, 2023
@andreisilviudragnea andreisilviudragnea deleted the NDEV-2438 branch December 12, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Deniskore Deniskore Deniskore approved these changes

@stanislav-tkach stanislav-tkach stanislav-tkach approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andreisilviudragnea @Deniskore @stanislav-tkach