NDEV-1837 Remove syscall_stub #277
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sts' into NDEV-1837_solana_compasibility
Collaborator
anton-lisanin
left a comment
anton-lisanin
left a comment
There was a problem hiding this comment.
You can remove lib/src/syscall_stubs.rs
| .await? | ||
| .value | ||
| .unwrap(); | ||
| let rent = Rent::from_account_info(&AccountInfo { |
Collaborator
There was a problem hiding this comment.
This can be simplified to
let rent = bincode::deserialize(&rent_account.data)
| }; | ||
|
|
||
| // TODO: is it correct to get rent from the account | ||
| let mut rent_account = rpc |
| .get_account(&solana_sdk::sysvar::rent::id()) | ||
| .await? | ||
| .value | ||
| .unwrap(); |
Collaborator
There was a problem hiding this comment.
Check for error instead of unwarping
| } | ||
|
|
||
| fn rent(&self) -> &Rent { | ||
| unimplemented!(); |
Collaborator
There was a problem hiding this comment.
Why unimplemented!?
Author
There was a problem hiding this comment.
This TestDatabase is used only for cargo tests and rent() method isn't required.
| } | ||
|
|
||
| #[cfg(target_os = "solana")] | ||
| macro_rules! log_msg { |
Collaborator
There was a problem hiding this comment.
What is the difference between debug_print and log_msg?
Author
There was a problem hiding this comment.
debug_print doesn't show any line in program, log_msg is replacement for solana_program::msg macros.
Collaborator
|
Will be merged to 1.9.x as part of #281 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log_data()andlog_msg()to work with our implementation instead ofsyscall_stabin emulation context