Skip to content

feat(): support typeorm ^0.3.0 version #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 1, 2022
Merged

feat(): support typeorm ^0.3.0 version #1233

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9001b56
feat(): support typeorm ^0.3.0 version
kamilmysliwiec Apr 1, 2022
42d0e92
chore(): resolve merge conflicts
kamilmysliwiec Apr 1, 2022
9ce3a03
Update lib/common/typeorm.decorators.ts
kamilmysliwiec Apr 2, 2022
2f91da4
chore(): add inject connection alias and mark it as deprecated
kamilmysliwiec Apr 7, 2022
3d3a3f1
feat(): add get connection token alias for backward comp
kamilmysliwiec Apr 8, 2022
a5e84c1
fix: check if the dataSource is initialized before destroying it
May 11, 2022
3b14f13
Merge pull request #1269 from thomasconner/feat/typeorm-0.3-migration
kamilmysliwiec May 20, 2022
1f699cd
chore(): resolve conflicts
kamilmysliwiec Jun 1, 2022
d4ff918
Merge branch 'feat/typeorm-0.3-migration' of https://github.com/nestj…
kamilmysliwiec Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: check if the dataSource is initialized before destroying it
  • Loading branch information
Thomas Conner committed May 11, 2022
commit a5e84c154f5f51fc94d0569f73aa0c67b6a9d515
4 changes: 3 additions & 1 deletion lib/typeorm-core.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,9 @@ export class TypeOrmCoreModule implements OnApplicationShutdown {
getDataSourceToken(this.options as DataSourceOptions) as Type<DataSource>,
);
try {
dataSource && (await dataSource.destroy());
if (dataSource && dataSource.isInitialized) {
await dataSource.destroy();
}
} catch (e) {
this.logger.error(e?.message);
}
Expand Down