Add test container based on Alpine image. #953
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amirouche A BOUBEKKI <[email protected]>
ctalledo
reviewed
Aug 29, 2025
There was a problem hiding this comment.
Thanks @amirouche for the contribution!
However it's missing a small part (see review comment).
| # Instructions: https://cri-o.io/ | ||
| RUN apk update && apk add cri-o | ||
|
|
||
|
|
There was a problem hiding this comment.
We are missing the installation of the Nestybox forked CRI-O here, as well as crictl and CNIs; similar to:
168 │ # Build and install the Nestybox CRI-O (for testing deployment of pods with sysbox (aka "sysbox pods"))
169 │ RUN apt-get update && apt-get install -y --no-install-recommends libgpgme-dev \
170 │ && mkdir -p /tmp/crio-build \
171 │ && git clone https://github.com/nestybox/cri-o.git /tmp/crio-build/cri-o \
172 │ && git -C /tmp/crio-build/cri-o checkout -b ${crio_version}-sysbox origin/${crio_version}-sysbox \
173 │ && cd /tmp/crio-build/cri-o && make binaries \
174 │ && mv /usr/bin/crio /usr/bin/crio.orig \
175 │ && cp /tmp/crio-build/cri-o/bin/crio-static /usr/bin/crio \
176 │ && rm -rf /tmp/crio-build
178 │ RUN wget https://github.com/kubernetes-sigs/cri-tools/releases/download/${crictl_version}/crictl-${crictl_version}-linux-${sys_arch}.tar.gz \
179 │ && sudo tar zxvf crictl-${crictl_version}-linux-${sys_arch}.tar.gz -C /usr/local/bin \
180 │ && rm -f crictl-${crictl_version}-linux-${sys_arch}.tar.gz
181 │
182 │ # Container CNIs (needed by CRI-O)
183 │ RUN curl -fsSL https://pkgs.k8s.io/core:/stable:/${k8s_version}/deb/Release.key | gpg --dearmor -o /etc/apt/keyrings/kubernetes-apt-keyring.gpg \
184 │ && echo "deb [signed-by=/etc/apt/keyrings/kubernetes-apt-keyring.gpg] https://pkgs.k8s.io/core:/stable:/${k8s_version}/deb/ /" | tee /etc/apt/sources.list.d/kubernetes.list \
185 │ && apt-get update \
186 │ && apt-get install kubernetes-cni
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It compiles sysbox, and after configuring the host docker, and running sysbox daemons, I can do:
then login with admin/admin, then:
but
make testerrors, and among the unit tests onlymake test-mgrsucceeds.