Skip to content

fix(tracing): actually set the tracing options in the root context #5118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 12 commits into from
Jul 5, 2023
Merged

fix(tracing): actually set the tracing options in the root context #5118

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cd44968
fix(tracing): actually set the tracing options in the root context
JGAntunes Jul 3, 2023
8bc9de3
chore: try to skip the warning logs
JGAntunes Jul 4, 2023
ed6ff40
fix: don't pass over description
JGAntunes Jul 4, 2023
7e44b07
chore: enable debug mode for tracing
JGAntunes Jul 4, 2023
18b3d77
fix: actually setup the protocol to grpc
JGAntunes Jul 4, 2023
eb62165
fix: plugin names for spans
JGAntunes Jul 4, 2023
62cab00
chore: remove auto instrumentation
JGAntunes Jul 4, 2023
3fb3182
chore: remove verbose logging
JGAntunes Jul 4, 2023
edf7b83
chore: add some docs
JGAntunes Jul 4, 2023
51da7ef
Merge branch 'main' into fix/trace-properties-handover
kodiakhq[bot] Jul 5, 2023
2103437
Merge branch 'main' into fix/trace-properties-handover
kodiakhq[bot] Jul 5, 2023
705b93a
Merge branch 'main' into fix/trace-properties-handover
kodiakhq[bot] Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: don't pass over description
  • Loading branch information
@JGAntunes
JGAntunes committed Jul 4, 2023
commit ed6ff40db7e365e27914ef4d4591cf813d5e2cb2
1 change: 0 additions & 1 deletion packages/build/src/steps/run_step.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ export const runStep = async function ({
// Add relevant attributes to the upcoming span context
const attributes: StepExecutionAttributes = {
'build.execution.step.name': coreStepName,
'build.execution.step.description': coreStepDescription,
'build.execution.step.package_name': packageName,
'build.execution.step.id': coreStepId,
'build.execution.step.loaded_from': loadedFrom,
Expand Down